[PATCH 1/2] Add watch for RFCOMM disconnect to HFP HF role

[PATCH 1/2] Add watch for RFCOMM disconnect to HFP HF role

[Frédéric Dalleau]

---
 audio/gateway.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/audio/gateway.c b/audio/gateway.c
index 345f397..77aec59 100644
--- a/audio/gateway.c
+++ b/audio/gateway.c
@@ -192,9 +192,26 @@ static void sco_connect_cb(GIOChannel *chan, GError *err, gpointer user_data)
 				(GIOFunc) sco_io_cb, dev);
 }
 
+static gboolean rfcomm_disconnect_cb(GIOChannel *chan, GIOCondition cond,
+			struct audio_device *dev)
+{
+	struct gateway *gw = dev->gateway;
+
+	if (cond & G_IO_NVAL)
+		return FALSE;
+
+	g_io_channel_shutdown(gw->rfcomm, TRUE, NULL);
+	g_io_channel_unref(gw->rfcomm);
+	gw->rfcomm = NULL;
+	change_state(dev, GATEWAY_STATE_DISCONNECTED);
+
+	return FALSE;
+}
+
 static void newconnection_reply(DBusPendingCall *call, void *data)
 {
 	struct audio_device *dev = data;
+	struct gateway *gw = dev->gateway;
 	DBusMessage *reply = dbus_pending_call_steal_reply(call);
 	DBusError derr;
 
@@ -206,6 +223,8 @@ static void newconnection_reply(DBusPendingCall *call, void *data)
 	dbus_error_init(&derr);
 	if (!dbus_set_error_from_message(&derr, reply)) {
 		DBG("Agent reply: file descriptor passed successfully");
+		g_io_add_watch(gw->rfcomm, G_IO_ERR | G_IO_HUP | G_IO_NVAL,
+					(GIOFunc) rfcomm_disconnect_cb, dev);
 		change_state(dev, GATEWAY_STATE_CONNECTED);
 		goto done;
 	}
-- 
1.7.1

[PATCH 2/2] Minor style fix in audio/gateway.c

[Frédéric Dalleau]

---
 audio/gateway.c |   15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/audio/gateway.c b/audio/gateway.c
index 77aec59..e9485d0 100644
--- a/audio/gateway.c
+++ b/audio/gateway.c
@@ -158,16 +158,13 @@ static gboolean sco_io_cb(GIOChannel *chan, GIOCondition cond,
 	if (cond & G_IO_NVAL)
 		return FALSE;
 
-	if (cond & (G_IO_ERR | G_IO_HUP)) {
-		DBG("sco connection is released");
-		g_io_channel_shutdown(gw->sco, TRUE, NULL);
-		g_io_channel_unref(gw->sco);
-		gw->sco = NULL;
-		change_state(dev, GATEWAY_STATE_CONNECTED);
-		return FALSE;
-	}
+	DBG("sco connection is released");
+	g_io_channel_shutdown(gw->sco, TRUE, NULL);
+	g_io_channel_unref(gw->sco);
+	gw->sco = NULL;
+	change_state(dev, GATEWAY_STATE_CONNECTED);
 
-	return TRUE;
+	return FALSE;
 }
 
 static void sco_connect_cb(GIOChannel *chan, GError *err, gpointer user_data)
-- 
1.7.1

Re: [PATCH 1/2] Add watch for RFCOMM disconnect to HFP HF role

[Johan Hedberg]

Hi Frédéric,

On Thu, Aug 04, 2011, Frédéric Dalleau wrote:
> ---
>  audio/gateway.c |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)

Both patches have been applied. Thanks.

Johan