* [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue
@ 2011-08-08 14:48 Lucas De Marchi
2011-08-08 19:21 ` Luiz Augusto von Dentz
2011-08-09 7:22 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Lucas De Marchi @ 2011-08-08 14:48 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz; +Cc: Lucas De Marchi
According to AVRCP spec there's no player id in response.
---
parser/avrcp.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/parser/avrcp.c b/parser/avrcp.c
index 485bb55..f8e4443 100644
--- a/parser/avrcp.c
+++ b/parser/avrcp.c
@@ -612,7 +612,7 @@ response:
printf("ValueCount: 0x%02x\n", num);
for (; num > 0; num--) {
- uint8_t attr, player, value;
+ uint8_t attr, value;
p_indent(level, frm);
@@ -621,11 +621,6 @@ response:
p_indent(level, frm);
- player = get_u8(frm);
- printf("Player: 0x%02x\n", player);
-
- p_indent(level, frm);
-
value = get_u8(frm);
printf("ValueID: 0x%02x (%s)\n", value,
value2str(attr, value));
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue
2011-08-08 14:48 [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue Lucas De Marchi
@ 2011-08-08 19:21 ` Luiz Augusto von Dentz
2011-08-09 7:22 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2011-08-08 19:21 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: linux-bluetooth
Hi Lucas,
On Mon, Aug 8, 2011 at 5:48 PM, Lucas De Marchi
<lucas.demarchi@profusion.mobi> wrote:
> According to AVRCP spec there's no player id in response.
> ---
> parser/avrcp.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/parser/avrcp.c b/parser/avrcp.c
> index 485bb55..f8e4443 100644
> --- a/parser/avrcp.c
> +++ b/parser/avrcp.c
> @@ -612,7 +612,7 @@ response:
> printf("ValueCount: 0x%02x\n", num);
>
> for (; num > 0; num--) {
> - uint8_t attr, player, value;
> + uint8_t attr, value;
>
> p_indent(level, frm);
>
> @@ -621,11 +621,6 @@ response:
>
> p_indent(level, frm);
>
> - player = get_u8(frm);
> - printf("Player: 0x%02x\n", player);
> -
> - p_indent(level, frm);
> -
> value = get_u8(frm);
> printf("ValueID: 0x%02x (%s)\n", value,
> value2str(attr, value));
> --
> 1.7.6
Nice catch, I guess I got confused because of the page break.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue
2011-08-08 14:48 [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue Lucas De Marchi
2011-08-08 19:21 ` Luiz Augusto von Dentz
@ 2011-08-09 7:22 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2011-08-09 7:22 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: linux-bluetooth, luiz.dentz
Hi Lucas,
On Mon, Aug 08, 2011, Lucas De Marchi wrote:
> According to AVRCP spec there's no player id in response.
> ---
> parser/avrcp.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
Applied. Thanks.
Feel free to tag hcidump patches with [PATCH hcidump] in the future.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-09 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 14:48 [PATCH] Fix response for GetCurrentPlayerApplicationSettingValue Lucas De Marchi
2011-08-08 19:21 ` Luiz Augusto von Dentz
2011-08-09 7:22 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).