From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] Fix missing Name header check in FTP action code
Date: Tue, 9 Aug 2011 13:00:37 +0300 [thread overview]
Message-ID: <20110809100037.GA19242@dell> (raw)
In-Reply-To: <1312879479-4577-1-git-send-email-lkslawek@gmail.com>
Hi Slawek,
On Tue, Aug 09, 2011, Slawomir Bochenski wrote:
> ---
> plugins/ftp.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
Applied, but with a minor coding-style modification:
> name = obex_get_name(os);
> +
> + if (name == NULL || !is_filename(name))
> + return -EBADR;
Usually when we have an assignment to a variable and then an immediately
following check for the variable there's no empty line between the
assignment and the if-statement, so I removed this empty line.
Johan
prev parent reply other threads:[~2011-08-09 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 8:44 [PATCH obexd] Fix missing Name header check in FTP action code Slawomir Bochenski
2011-08-09 10:00 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809100037.GA19242@dell \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lkslawek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).