From: Gustavo Padovan <padovan@profusion.mobi>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Jaikumar Ganesh <jaikumar@google.com>
Subject: Re: [PATCH v2] Bluetooth: bnep: Fix deadlock in session deletion
Date: Thu, 11 Aug 2011 18:05:33 -0300 [thread overview]
Message-ID: <20110811210532.GC19699@joana> (raw)
In-Reply-To: <1312555295.2172.2.camel@THOR>
Hi Peter,
* Peter Hurley <peter@hurleysoftware.com> [2011-08-05 10:41:35 -0400]:
> Commit f4d7cd4a4c introduced the usage of kthread API.
> kthread_stop is a blocking function which returns only when
> the thread exits. In this case, the thread can't exit because it's
> waiting for the write lock, which is being held by bnep_del_connection()
> which is waiting for the thread to exit -- deadlock.
>
> Use atomic_t/wake_up_process instead to signal to the thread to exit.
>
> Signed-off-by: Jaikumar Ganesh <jaikumar@google.com>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> net/bluetooth/bnep/bnep.h | 1 +
> net/bluetooth/bnep/core.c | 9 +++++----
> 2 files changed, 6 insertions(+), 4 deletions(-)
Applied, thanks.
Gustavo
prev parent reply other threads:[~2011-08-11 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 14:41 [PATCH v2] Bluetooth: bnep: Fix deadlock in session deletion Peter Hurley
2011-08-11 21:05 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811210532.GC19699@joana \
--to=padovan@profusion.mobi \
--cc=jaikumar@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).