Re: [PATCH 1/8] Off-by-one(two) error in form factor detection

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Pavel,

On Tue, Aug 16, 2011, Pavel Raiskup wrote:
> Indexing of chassis_map array has to be done like that:
>     chassis_map[chassis_type * 2 - 1]
> 
> because if not, everything is shifted by one. When (e.g.) chassis_type
> is 0x04 result should be "Low Profile Desktop" =>  "desktop" (not a
> "Pizza Box" => "server"). Lets see the 2.6.1 document on:
> 
> http://www.dmtf.org/standards/smbios
> ---
>  plugins/formfactor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

The patch doesn't apply (probably due to your email client splitting
lines). You might want to consider using git send-email instead:

Applying: Off-by-one(two) error in form factor detection
fatal: corrupt patch at line 10
Patch failed at 0001 Off-by-one(two) error in form factor detection

I also added Łukasz to CC since he sent a patch to this very same line a
month ago or so (and introduced the "+ 1). Łukasz, did you really verify
the correctness of your patch? (it seems you didn't)

Johan