Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH BlueZ 1/8] Add link_type information to the mgmt "Device Connected" event
Date: Wed, 31 Aug 2011 10:51:15 +0300	[thread overview]
Message-ID: <20110831075115.GA6348@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1313798969-8772-2-git-send-email-vinicius.gomes@openbossa.org>

Hi Vinicius,

On Fri, Aug 19, 2011, Vinicius Costa Gomes wrote:
> --- a/lib/hci.h
> +++ b/lib/hci.h
> @@ -212,6 +212,8 @@ enum {
>  #define SCO_LINK	0x00
>  #define ACL_LINK	0x01
>  #define ESCO_LINK	0x02
> +/* Low Energy links do not have defined link type. Use invented one */
> +#define LE_LINK		0x80

I remember Marcel being against any self-invented additions like this.
Have you discussed this with him?

Johan

  reply	other threads:[~2011-08-31  7:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20  0:09 [PATCH BlueZ 0/8] Proper support for pairing LE devices Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 1/8] Add link_type information to the mgmt "Device Connected" event Vinicius Costa Gomes
2011-08-31  7:51   ` Johan Hedberg [this message]
2011-08-31 11:25     ` Luiz Augusto von Dentz
2011-08-31 12:27       ` Johan Hedberg
2011-08-20  0:09 ` [PATCH BlueZ 2/8] Fix doing SDP service discovery for LE devices Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 3/8] Set the Paired property of a device when restoring from storage Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 4/8] Fix not using the same way for pairing LE devices Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 5/8] Fix not using the "bonded" property for new bondings Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 6/8] Fix connecting to the local adapter when receiving new keys Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 7/8] Remove the default security level from btio Vinicius Costa Gomes
2011-08-20  0:09 ` [PATCH BlueZ 8/8] Fix btio users to not expect a default security level Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110831075115.GA6348@dell.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox