* [PATCH BlueZ v2] Fix remove emitting Paired=false when deleting device
@ 2011-09-20 19:09 Dmitriy Paliy
2011-09-27 9:18 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Dmitriy Paliy @ 2011-09-20 19:09 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dmitriy Paliy
When adapter is requested to remove device, device's property
Paired=false is emitted after the adapter notifies clients that
list Devices is empty. Some clients get confused.
Emitting property was introduced in clean-up patch
c92a4af85f480c16f3ff017783c821304c899ce5. Since such notification
does not have practical meaning, it is better to remove it.
---
src/device.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/device.c b/src/device.c
index 96e798f..3a2d88f 100644
--- a/src/device.c
+++ b/src/device.c
@@ -992,7 +992,8 @@ static void device_remove_stored(struct btd_device *device)
delete_entry(&src, "linkkeys", addr);
delete_entry(&src, "aliases", addr);
device_set_bonded(device, FALSE);
- device_set_paired(device, FALSE);
+ device->paired = FALSE;
+ btd_adapter_remove_bonding(device->adapter, &device->bdaddr);
}
delete_entry(&src, "profiles", addr);
delete_entry(&src, "trusts", addr);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ v2] Fix remove emitting Paired=false when deleting device
2011-09-20 19:09 [PATCH BlueZ v2] Fix remove emitting Paired=false when deleting device Dmitriy Paliy
@ 2011-09-27 9:18 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-09-27 9:18 UTC (permalink / raw)
To: Dmitriy Paliy; +Cc: linux-bluetooth, Dmitriy Paliy
Hi Dmitriy,
On Tue, Sep 20, 2011, Dmitriy Paliy wrote:
> When adapter is requested to remove device, device's property
> Paired=false is emitted after the adapter notifies clients that
> list Devices is empty. Some clients get confused.
>
> Emitting property was introduced in clean-up patch
> c92a4af85f480c16f3ff017783c821304c899ce5. Since such notification
> does not have practical meaning, it is better to remove it.
> ---
> src/device.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-27 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-20 19:09 [PATCH BlueZ v2] Fix remove emitting Paired=false when deleting device Dmitriy Paliy
2011-09-27 9:18 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).