* [PATCH] Fix freeing watches list in maemo6 telephony
@ 2011-09-21 12:49 Dmitriy Paliy
2011-09-21 13:09 ` Luiz Augusto von Dentz
2011-09-27 9:21 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Dmitriy Paliy @ 2011-09-21 12:49 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dmitriy Paliy
This fixes regression introduced in 83064481481d23523e5cdd04.
List watches has to be freed instead of list pending.
---
audio/telephony-maemo6.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
index a5845c4..42d693a 100644
--- a/audio/telephony-maemo6.c
+++ b/audio/telephony-maemo6.c
@@ -2017,7 +2017,7 @@ void telephony_exit(void)
g_slist_free_full(pending, pending_req_finalize);
pending = NULL;
- g_slist_free_full(pending, remove_watch);
+ g_slist_free_full(watches, remove_watch);
watches = NULL;
dbus_connection_unref(connection);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix freeing watches list in maemo6 telephony
2011-09-21 12:49 [PATCH] Fix freeing watches list in maemo6 telephony Dmitriy Paliy
@ 2011-09-21 13:09 ` Luiz Augusto von Dentz
2011-09-27 9:21 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2011-09-21 13:09 UTC (permalink / raw)
To: Dmitriy Paliy; +Cc: linux-bluetooth
Hi Dmitriy,
On Wed, Sep 21, 2011 at 3:49 PM, Dmitriy Paliy <dmitriy.paliy@nokia.com> wrote:
> This fixes regression introduced in 83064481481d23523e5cdd04.
> List watches has to be freed instead of list pending.
> ---
> audio/telephony-maemo6.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
> index a5845c4..42d693a 100644
> --- a/audio/telephony-maemo6.c
> +++ b/audio/telephony-maemo6.c
> @@ -2017,7 +2017,7 @@ void telephony_exit(void)
> g_slist_free_full(pending, pending_req_finalize);
> pending = NULL;
>
> - g_slist_free_full(pending, remove_watch);
> + g_slist_free_full(watches, remove_watch);
> watches = NULL;
>
> dbus_connection_unref(connection);
> --
> 1.7.4.1
Nice catch, ack.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix freeing watches list in maemo6 telephony
2011-09-21 12:49 [PATCH] Fix freeing watches list in maemo6 telephony Dmitriy Paliy
2011-09-21 13:09 ` Luiz Augusto von Dentz
@ 2011-09-27 9:21 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2011-09-27 9:21 UTC (permalink / raw)
To: Dmitriy Paliy; +Cc: linux-bluetooth
Hi Dmitriy,
On Wed, Sep 21, 2011, Dmitriy Paliy wrote:
> This fixes regression introduced in 83064481481d23523e5cdd04.
> List watches has to be freed instead of list pending.
> ---
> audio/telephony-maemo6.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-27 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-21 12:49 [PATCH] Fix freeing watches list in maemo6 telephony Dmitriy Paliy
2011-09-21 13:09 ` Luiz Augusto von Dentz
2011-09-27 9:21 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).