From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] AVRCP: return empty string instead of rejecting
Date: Mon, 3 Oct 2011 11:54:30 +0300 [thread overview]
Message-ID: <20111003085430.GD8956@fusion.localdomain> (raw)
In-Reply-To: <1317249357-1362-1-git-send-email-lucas.demarchi@profusion.mobi>
Hi Lucas,
On Wed, Sep 28, 2011, Lucas De Marchi wrote:
> If media attribute is not available for a certain media file, return an
> empty string instead of rejecting the request. The spec is not so clear
> if only the title should be handled as an empty string when not present,
> but this is the only alternative to rejecting the request.
>
> IOP tests showed that some CT devices don't like reject messages: they
> never ask for an attribute again if they previously received a REJECTED
> message for that attribute. They consider REJECTED as "TG doesn't
> implement it these optional attributes" as opposed to what we had
> before, "this attribute is currently not available".
> ---
> audio/avrcp.c | 41 +++++++++++++++++++----------------------
> 1 files changed, 19 insertions(+), 22 deletions(-)
Both patches applied. Thanks.
Johan
prev parent reply other threads:[~2011-10-03 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 22:35 [PATCH 1/2] AVRCP: return empty string instead of rejecting Lucas De Marchi
2011-09-28 22:35 ` [PATCH 2/2] AVRCP: fix case when only one setting is provided Lucas De Marchi
2011-09-30 14:55 ` Luiz Augusto von Dentz
2011-09-30 14:54 ` [PATCH 1/2] AVRCP: return empty string instead of rejecting Luiz Augusto von Dentz
2011-10-03 8:54 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003085430.GD8956@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox