From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] Fix using the attribute struct for encoding ATT pdus
Date: Thu, 6 Oct 2011 19:08:34 +0300 [thread overview]
Message-ID: <20111006160834.GA11338@fusion.localdomain> (raw)
In-Reply-To: <1317911897-6567-1-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Thu, Oct 06, 2011, Vinicius Costa Gomes wrote:
> The enconding and decoding of ATT pdus should be kept as much
> free of dependences from other parts of the code as possible, so
> it can be used in many contexts.
>
> In this case, for encoding and decoding notifications and indications
> we did have to pass an instance of an attribute instead of direct
> values.
> ---
> attrib/att.c | 45 +++++++++++++++++++++++++--------------------
> attrib/att.h | 9 ++++++---
> 2 files changed, 31 insertions(+), 23 deletions(-)
Did you forget to include the changes to the places where this API is
used? The source tree should remain compilable between each individual
commit (to maintain e.g. bisectability) and that's not happening with
your patch.
Johan
next prev parent reply other threads:[~2011-10-06 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 14:38 [PATCH BlueZ] Fix using the attribute struct for encoding ATT pdus Vinicius Costa Gomes
2011-10-06 16:08 ` Johan Hedberg [this message]
2011-10-06 16:24 ` Vinicius Costa Gomes
2011-10-06 18:01 ` Vinicius Costa Gomes
2011-10-07 20:25 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006160834.GA11338@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox