From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] Bluetooth: convert flushable variable to flag in l2cap chan
Date: Mon, 10 Oct 2011 10:35:32 +0300 [thread overview]
Message-ID: <20111010073530.GA12512@aemeltch-MOBL1> (raw)
In-Reply-To: <20111007182214.GA2695@joana>
Hi Gustavo,
On Fri, Oct 07, 2011 at 03:22:14PM -0300, Gustavo Padovan wrote:
> > diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> > index 61f1f62..81fc8f0 100644
> > --- a/net/bluetooth/l2cap_sock.c
> > +++ b/net/bluetooth/l2cap_sock.c
> > @@ -446,14 +446,15 @@ static int l2cap_sock_getsockopt(struct socket *sock, int level, int optname, ch
> > break;
> >
> > case BT_FLUSHABLE:
> > - if (put_user(chan->flushable, (u32 __user *) optval))
> > + if (put_user(test_bit(FLAG_FLUSHABLE, &chan->flags),
> > + (u32 __user *) optval))
> > err = -EFAULT;
> >
> > break;
> >
> > case BT_POWER:
> > if (sk->sk_type != SOCK_SEQPACKET && sk->sk_type != SOCK_STREAM
> > - && sk->sk_type != SOCK_RAW) {
> > + && sk->sk_type != SOCK_RAW) {
>
> This change doesn't belong to this patch. Please fix this and resend.
I've just sent patch without this cosmetic change.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2011-10-10 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 13:54 [PATCH 1/4] Bluetooth: convert flushable variable to flag in l2cap chan Emeltchenko Andrei
2011-10-07 13:54 ` [PATCH 2/4] Bluetooth: convert force_reliable " Emeltchenko Andrei
2011-10-07 13:54 ` [PATCH 3/4] Bluetooth: convert force_active " Emeltchenko Andrei
2011-10-07 13:54 ` [PATCH 4/4] Bluetooth: convert role_switch " Emeltchenko Andrei
2011-10-07 18:22 ` [PATCH 1/4] Bluetooth: convert flushable " Gustavo Padovan
2011-10-10 7:35 ` Emeltchenko Andrei [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-10 7:33 Emeltchenko Andrei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010073530.GA12512@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox