From: Johan Hedberg <johan.hedberg@gmail.com>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2 hcidump 3/3] decode fixed channel list info rsp
Date: Fri, 14 Oct 2011 22:15:54 +0300 [thread overview]
Message-ID: <20111014191554.GA8723@fusion.localdomain> (raw)
In-Reply-To: <1318408296-28840-4-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Wed, Oct 12, 2011, Emeltchenko Andrei wrote:
> @@ -241,6 +250,8 @@ static uint32_t get_val(uint8_t *ptr, uint8_t len)
> return btohs(bt_get_unaligned((uint16_t *) ptr));
> case 4:
> return btohl(bt_get_unaligned((uint32_t *) ptr));
> + case 8:
> + return btohll(bt_get_unaligned((uint64_t *) ptr));
> }
> return 0;
> }
Looks to me like you've forgotten to update the return type of get_val()
from uint32_t to uint64_t. Other than that I haven't spotted any major
issues with this patch series.
Johan
next prev parent reply other threads:[~2011-10-14 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 8:31 [PATCHv2 hcidump 0/3] decode fixed channels Emeltchenko Andrei
2011-10-12 8:31 ` [PATCHv2 hcidump 1/3] add btohll macro Emeltchenko Andrei
2011-10-12 8:31 ` [PATCHv2 hcidump 2/3] add fixed channel definitions Emeltchenko Andrei
2011-10-12 8:31 ` [PATCHv2 hcidump 3/3] decode fixed channel list info rsp Emeltchenko Andrei
2011-10-14 19:15 ` Johan Hedberg [this message]
2011-10-17 8:22 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014191554.GA8723@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox