From: Johan Hedberg <johan.hedberg@gmail.com>
To: Peter Krystad <pkrystad@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 bluez 2/2] Add A2MP definitions
Date: Fri, 28 Oct 2011 15:22:42 +0300 [thread overview]
Message-ID: <20111028122242.GB21308@fusion.localdomain> (raw)
In-Reply-To: <1319761719-16363-3-git-send-email-pkrystad@codeaurora.org>
Hi Peter,
On Thu, Oct 27, 2011, Peter Krystad wrote:
> +typedef struct {
> + uint8_t code;
> + uint8_t ident;
> + uint16_t len;
> +} __attribute__ ((packed)) a2mp_hdr;
Even though the legacy user space code uses typedefs for HCI and L2CAP
(which is why typedefs are probably ok for your 1st patch) the general
direction should be to try to get rid of them where they're not strictly
necessary. The kernel side headers don't use them either (take a look at
include/net/bluetooth/l2cap.h and hci.h).
Therefore, I think it'd be good if you'd from the start avoid them in
this a2mp code. Later it'd be good to have a cleanup patch to convert
the L2CAP and HCI definitions to not use them either.
Johan
next prev parent reply other threads:[~2011-10-28 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 0:28 [PATCH v2 bluez 0/2] Add BT 3.0+HS definitions Peter Krystad
2011-10-28 0:28 ` [PATCH v2 bluez 1/2] Add L2CAP Create/Move Channel definitions Peter Krystad
2011-10-28 0:28 ` [PATCH v2 bluez 2/2] Add A2MP definitions Peter Krystad
2011-10-28 12:22 ` Johan Hedberg [this message]
2011-10-28 21:04 ` Peter Krystad
2011-10-28 11:17 ` [PATCH v2 bluez 0/2] Add BT 3.0+HS definitions Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028122242.GB21308@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox