* [PATCH] Bluetooth: Set HCI_MGMT flag only in read_controller_info
@ 2011-10-24 20:36 johan.hedberg
2011-10-31 19:31 ` Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: johan.hedberg @ 2011-10-24 20:36 UTC (permalink / raw)
To: linux-bluetooth
From: Johan Hedberg <johan.hedberg@intel.com>
The HCI_MGMT flag should only be set when user space requests the full
controller information. This way we avoid potential issues with setting
change events ariving before the actual read_controller_info command
finishes.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/mgmt.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 9ffd7c3..b086c69 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -151,8 +151,6 @@ static int read_index_list(struct sock *sk)
hci_del_off_timer(d);
- set_bit(HCI_MGMT, &d->flags);
-
if (test_bit(HCI_SETUP, &d->flags))
continue;
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Set HCI_MGMT flag only in read_controller_info
2011-10-24 20:36 [PATCH] Bluetooth: Set HCI_MGMT flag only in read_controller_info johan.hedberg
@ 2011-10-31 19:31 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2011-10-31 19:31 UTC (permalink / raw)
To: johan.hedberg; +Cc: linux-bluetooth
Hi Johan,
* johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2011-10-24 22:36:26 +0200]:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> The HCI_MGMT flag should only be set when user space requests the full
> controller information. This way we avoid potential issues with setting
> change events ariving before the actual read_controller_info command
> finishes.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> net/bluetooth/mgmt.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Applied, thanks.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-31 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24 20:36 [PATCH] Bluetooth: Set HCI_MGMT flag only in read_controller_info johan.hedberg
2011-10-31 19:31 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).