linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <padovan@profusion.mobi>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: ath3k: Use GFP_KERNEL instead of GFP_ATOMIC
Date: Mon, 31 Oct 2011 17:38:07 -0200	[thread overview]
Message-ID: <20111031193807.GH10164@joana> (raw)
In-Reply-To: <1319537392-4993-1-git-send-email-dh.herrmann@googlemail.com>

Hi David,

* David Herrmann <dh.herrmann@googlemail.com> [2011-10-25 12:09:52 +0200]:

> We are allowed to sleep here so no need to use GFP_ATOMIC. The caller
> (ath3k_probe) calls request_firmware() which definitely sleeps. Hence, we should
> avoid using GFP_ATOMIC.
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> V2: This fixes both occurences of GFP_ATOMIC in one patch.
> 
>  drivers/bluetooth/ath3k.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

	Gustavo

      reply	other threads:[~2011-10-31 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  9:49 [PATCH] Bluetooth: ath3k: Use GFP_KERNEL instead of GFP_ATOMIC David Herrmann
2011-10-25 10:09 ` [PATCH v2] " David Herrmann
2011-10-31 19:38   ` Gustavo Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111031193807.GH10164@joana \
    --to=padovan@profusion.mobi \
    --cc=dh.herrmann@googlemail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).