From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix mgmt response when adapter goes down or is removed
Date: Thu, 3 Nov 2011 14:35:51 +0200 [thread overview]
Message-ID: <20111103123551.GA16065@fusion.localdomain> (raw)
In-Reply-To: <20111103123159.GA16087@aemeltch-MOBL1>
Hi Andrei,
On Thu, Nov 03, 2011, Andrei Emeltchenko wrote:
> > @@ -1956,6 +1964,10 @@ int mgmt_index_added(u16 index)
> >
> > int mgmt_index_removed(u16 index)
> > {
> > + uint8_t status = ENODEV;
>
> Does it make sense to mix type naming here and below? (u8, u16, uint8_t, uint16_t)
No, it doesn't make sense. It should be u8, u16, etc. This is just my
strong user-space background shining through. Will send a v2 in a
minute.
Johan
next prev parent reply other threads:[~2011-11-03 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 10:58 [PATCH] Bluetooth: Fix mgmt response when adapter goes down or is removed johan.hedberg
2011-11-03 12:32 ` Andrei Emeltchenko
2011-11-03 12:35 ` Johan Hedberg [this message]
2011-11-03 12:40 ` [PATCH v2] " johan.hedberg
2011-11-03 14:32 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103123551.GA16065@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox