From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 obexd] phonebook-tracker: Seek for contact name deeper
Date: Mon, 14 Nov 2011 17:33:38 +0200 [thread overview]
Message-ID: <20111114153338.GA6994@fusion.localdomain> (raw)
In-Reply-To: <1321281112-26363-1-git-send-email-lkslawek@gmail.com>
Hi Slawek,
On Mon, Nov 14, 2011, Slawomir Bochenski wrote:
> Some contacts in Tracker can have no name fields set nor nickname. This
> patch enhances the way the contact name is obtained:
>
> 1) If there is no nco:nickname set for contact, use nco:imNickname from
> its related IM data.
> 2) As the N field is mandatory in both vCard 2.1 and 3.0 and it's the
> most useful field for PBAP clients, if its components are not present
> in Tracker, use nco:fullname (thus promote FN to N) or if nco:fullname
> is also not present, then use previously obtained nickname for N field.
> ---
>
> v2: changed 0 to '\0' in char type comparisons
>
> plugins/phonebook-tracker.c | 91 ++++++++++++++++++++++++++++++++++++++-----
> 1 files changed, 81 insertions(+), 10 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2011-11-14 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 13:30 [PATCH obexd] phonebook-tracker: Seek for contact name deeper Slawomir Bochenski
2011-11-14 14:17 ` Johan Hedberg
2011-11-14 14:31 ` [PATCH v2 " Slawomir Bochenski
2011-11-14 15:33 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114153338.GA6994@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lkslawek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox