linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Bartosz Szatkowski <bulislaw@linux.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] gobex: Fix setpath to match one from OBEX spec
Date: Wed, 16 Nov 2011 14:00:43 +0200	[thread overview]
Message-ID: <20111116120043.GA3873@x220> (raw)
In-Reply-To: <CA+i+Aw2UJMhfegpB3Odmzyhv9khYKtt-9tJzX1Y2kXDqsgCCgQ@mail.gmail.com>

Hi, Slawek,

On Wed, Nov 16, 2011, Slawomir Bochenski wrote:
> The function itself is quite useful for MAP clients. There is this
> fixed part of directories structure in MAP, which is:
> 
> telecom
>  '- msg
>      |- inbox
>      |- outbox
>      |- sent
>      |- deleted
>      '- draft
> 
> There are no messages in msg, thus going from e.g. outbox to sent
> directly seems convenient.
> 
> I do not understand why you are so reluctant to have function for
> setting path in gobex that actually offers what OBEX offers. As I
> mentioned already in discussion about MAP API proposal, this also
> gives additional restrictions on what characters one can use in folder
> name.
> 
> You at least have one example of profile that could have make use of
> it. So it won't be in effect anything that is not used.

I don't as such have anything against the possibility of supporting a
"cd ../foo" operation through the API, but the way that the OBEX spec
implements it feels like a hack that's been put in place as an
afterthought (they thought they'd get away with restricting path changes
to one level at a time and when they realized ../foo might make sense
instead of extending the name header they added this to flags (I don't
know if this is how things actually happened but it's the impression I
get). In OBEX 1.4 the DestName header was defined to tackle this
shortcoming of the Name header, but at that point it was too late to
have SetPath use it due to backwards compatibility reasons.

Anyway, there's no reason to expose this ugliness in our APIs and we can
still support the feature by allowing the application to pass "../foo"
as the path name.

Johan

      reply	other threads:[~2011-11-16 12:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 14:44 [PATCH] gobex: Fix setpath to match one from OBEX spec Bartosz Szatkowski
2011-11-15 22:29 ` Luiz Augusto von Dentz
2011-11-16  8:24   ` Bartosz Szatkowski
2011-11-16 11:12     ` Luiz Augusto von Dentz
2011-11-16 11:49       ` Slawomir Bochenski
2011-11-16 12:00         ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111116120043.GA3873@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lkslawek@gmail.com \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).