From: Gustavo Padovan <padovan@profusion.mobi>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Create a unique mgmt error code hierarchy
Date: Wed, 16 Nov 2011 16:11:00 -0200 [thread overview]
Message-ID: <20111116181100.GF16865@joana> (raw)
In-Reply-To: <1321027800-353-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
* johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2011-11-11 18:10:00 +0200]:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> The management protocol uses a single byte for error codes (aka command
> status). In some places this value is directly copied from HCI and in
> other a POSIX error number is used. This makes it impossible for
> user-space to uniquily decipher the meaning of an error.
>
> To solve this issue a new mgmt-specific set of error codes is added
> along with a conversion table for HCI status values.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> v2: Use ARRAY_SIZE() instead of a custom NELEM()
>
> include/net/bluetooth/mgmt.h | 17 +++
> net/bluetooth/mgmt.c | 315 ++++++++++++++++++++++++++++++------------
> 2 files changed, 241 insertions(+), 91 deletions(-)
It doesn't apply anymore, please rebase.
Gustavo
next prev parent reply other threads:[~2011-11-16 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 14:18 [PATCH 1/3] Bluetooth: Return success instead of EALREADY for mgmt commands johan.hedberg
2011-11-11 14:18 ` [PATCH 2/3] Bluetooth: Create a unique mgmt error code hierarchy johan.hedberg
2011-11-11 14:37 ` Anderson Lizardo
2011-11-11 15:59 ` Johan Hedberg
2011-11-11 16:10 ` [PATCH v2] " johan.hedberg
2011-11-11 16:49 ` Andre Guedes
2011-11-11 17:40 ` Johan Hedberg
2011-11-16 18:11 ` Gustavo Padovan [this message]
2011-11-16 21:05 ` Johan Hedberg
2011-11-16 22:51 ` Gustavo Padovan
2011-11-11 14:18 ` [PATCH 3/3] Bluetooth: Add missing cmd_complete for mgmt_load_link_keys johan.hedberg
2011-11-16 18:23 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116181100.GF16865@joana \
--to=padovan@profusion.mobi \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).