From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: Remove magic bluetooth version numbers
Date: Wed, 23 Nov 2011 17:19:15 +0200 [thread overview]
Message-ID: <20111123151914.GC4066@aemeltch-MOBL1> (raw)
In-Reply-To: <1322059738.29909.6.camel@aeonflux>
Hi Marcel,
On Wed, Nov 23, 2011 at 03:48:58PM +0100, Marcel Holtmann wrote:
> > +/* Bluetooth versions */
> > +#define BLUETOOTH_VER_1_1 1
> > +#define BLUETOOTH_VER_1_2 2
> > +#define BLUETOOTH_VER_2_0_EDR 3
> > +
>
> I am fine with the patch, but you need to use BLUETOOTH_VER_2_0 here
> since you have have 2.0 without EDR. Have a fun night reading with the
> Bluetooth SIG branding guidelines.
OK, I will remove EDR at the end. BTW: on a bluetooth web site there seems
to be different interpretation of those numbers:
Parameter Name Assigned Values
HCI_Version
0 Bluetooth Core Specification 1.0b
1 Bluetooth Core Specification 1.1
2 Bluetooth Core Specification 1.2
3 Bluetooth Core Specification 2.0 + EDR
4 Bluetooth Core Specification 2.1 + EDR
5 Bluetooth Core Specification 3.0 + HS
6 Bluetooth Core Specification 4.0
7 - 255 Reserved
Source:
https://www.bluetooth.org/technical/assignednumbers/hci.htm
Best regards
Andrei Emeltchenko
>
> Once you did that change, ACK.
>
> Regards
>
> Marcel
>
>
next prev parent reply other threads:[~2011-11-23 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 9:23 [PATCH 1/2] Bluetooth: Correct version check in hci_setup Emeltchenko Andrei
2011-11-23 9:23 ` [PATCH 2/2] Bluetooth: Remove magic bluetooth version numbers Emeltchenko Andrei
2011-11-23 14:48 ` Marcel Holtmann
2011-11-23 15:19 ` Emeltchenko Andrei [this message]
2011-11-25 11:39 ` Marcel Holtmann
2011-11-23 14:47 ` [PATCH 1/2] Bluetooth: Correct version check in hci_setup Marcel Holtmann
2011-12-02 11:22 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123151914.GC4066@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox