From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Don't set LE flags in mgmt_start_discovery()
Date: Thu, 24 Nov 2011 20:22:22 +0200 [thread overview]
Message-ID: <20111124182222.GA23469@fusion.localdomain> (raw)
In-Reply-To: <70B35869-720B-4A42-8E3C-84679BE805FC@openbossa.org>
Hi Andre,
On Thu, Nov 24, 2011, Andre Guedes wrote:
> I think I do not quite understand this change in start discovery
> command. How should the command work now?
>
> For instance, let's say we have the userspace always setting those bits
> (BR/EDR and LE). If the hardware doesn't support LE should the kernel
> return error?
No.
> Or do we expect it does a kind of "best effort" and runs the inquiry
> only?
Yes, I think that would make most sense from user-space perspective
"find all devices you can". As for BR/EDR specific discovery (with no LE
bits) or LE specific discovery (BR/EDR bit not set) if the hardware
doesn't support the request then in this case I think it would in fact
make sense to return an error.
Johan
next prev parent reply other threads:[~2011-11-24 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 19:51 [PATCH] Don't set LE flags in mgmt_start_discovery() Andre Guedes
2011-11-22 21:58 ` Johan Hedberg
2011-11-24 18:06 ` Andre Guedes
2011-11-24 18:22 ` Johan Hedberg [this message]
2011-11-24 18:29 ` Anderson Lizardo
2011-11-24 18:44 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124182222.GA23469@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox