From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2 8/8] Bluetooth: Complete Read Local Version HCI cmd
Date: Thu, 1 Dec 2011 15:23:29 +0200 [thread overview]
Message-ID: <20111201132328.GD2216@aemeltch-MOBL1> (raw)
In-Reply-To: <1322745177.26198.34.camel@aeonflux>
Hi Marcel,
On Thu, Dec 01, 2011 at 02:12:57PM +0100, Marcel Holtmann wrote:
> Hi Andrei,
>
> > Mark request status as done for Read Local Version HCI command.
> > ---
> > net/bluetooth/hci_event.c | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> > index a646310..e064aa1 100644
> > --- a/net/bluetooth/hci_event.c
> > +++ b/net/bluetooth/hci_event.c
> > @@ -598,7 +598,7 @@ static void hci_cc_read_local_version(struct hci_dev *hdev, struct sk_buff *skb)
> > BT_DBG("%s status 0x%x", hdev->name, rp->status);
> >
> > if (rp->status)
> > - return;
> > + goto done;
> >
> > hdev->hci_ver = rp->hci_ver;
> > hdev->hci_rev = __le16_to_cpu(rp->hci_rev);
> > @@ -612,6 +612,9 @@ static void hci_cc_read_local_version(struct hci_dev *hdev, struct sk_buff *skb)
> >
> > if (test_bit(HCI_INIT, &hdev->flags))
> > hci_setup(hdev);
> > +
> > +done:
> > + hci_req_complete(hdev, HCI_OP_READ_LOCAL_VERSION, rp->status);
> > }
>
> this is all getting out of control. We call hci_req_complete for random
> functions now. And that is because our init handling sucks.
You are right here. The reason for this patch is AMP initialization where
this HCI command is last and does not "complete itself".
Maybe we need to "complete" each HCI Request?
Best regards
Andrei Emeltchenko
prev parent reply other threads:[~2011-12-01 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 12:42 [PATCHv2 0/8] AMP/BREDR initialization patches Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 1/8] Bluetooth: remove old code Emeltchenko Andrei
2011-12-02 12:27 ` Gustavo Padovan
2011-12-01 12:42 ` [PATCHv2 2/8] Bluetooth: Split ctrl init to BREDR and AMP parts Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 3/8] Bluetooth: Add HCI Read Flow Control Mode function Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 4/8] Bluetooth: Initialize default flow control mode Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 5/8] Bluetooth: Add HCI Read Data Block Size function Emeltchenko Andrei
2011-12-01 13:13 ` Marcel Holtmann
2011-12-01 13:37 ` Emeltchenko Andrei
2011-12-02 12:25 ` Emeltchenko Andrei
2011-12-02 15:28 ` Marcel Holtmann
2011-12-01 12:42 ` [PATCHv2 6/8] Bluetooth: Recalculate sched for HCI block flow ctrl Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 7/8] Bluetooth: Use SNIFF mode only for BREDR controller Emeltchenko Andrei
2011-12-01 13:11 ` Marcel Holtmann
2011-12-01 13:32 ` Emeltchenko Andrei
2011-12-01 12:42 ` [PATCHv2 8/8] Bluetooth: Complete Read Local Version HCI cmd Emeltchenko Andrei
2011-12-01 13:12 ` Marcel Holtmann
2011-12-01 13:23 ` Emeltchenko Andrei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201132328.GD2216@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox