From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix byte order problems getting PSM through btio API
Date: Thu, 1 Dec 2011 22:34:34 +0200 [thread overview]
Message-ID: <20111201203434.GA16339@fusion.localdomain> (raw)
In-Reply-To: <CACLukzJExFe0cYZBwAcU70ajDODJ5_RxVYx4pDxRq9DQCj2z7g@mail.gmail.com>
Hi Santiago,
On Thu, Dec 01, 2011, Santiago Carot wrote:
> As far as I see, CID uses little endian as well, There are some parts
> in the code where the byte conversion is done when BT_IO_OPT_CID is
> provided, for example in l2cap_connect, Conversely, this attribute is
> being provided in bt_io_get without host endian conversion.
>
> Diving in the code I can see that the gatt-server is getting it in
> ./src/attrib-server.c:1039 so I guess that there is the same problem
> that we had in big endian architectures.
Please also take a look at the kernel side since that's the only way to
be sure. Last time I checked I saw byte-order conversion for CID but not
for PSM (i.e. PSM was expected in little endian whereas CID wasn't).
Johan
prev parent reply other threads:[~2011-12-01 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 16:36 [PATCH] Fix byte order problems getting PSM through btio API Santiago Carot-Nemesio
2011-11-30 16:44 ` Santiago Carot
2011-11-30 21:16 ` Johan Hedberg
2011-12-01 19:31 ` Santiago Carot
2011-12-01 20:34 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201203434.GA16339@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox