From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] hdp_util: Fix coding style issues
Date: Fri, 2 Dec 2011 13:54:20 +0200 [thread overview]
Message-ID: <20111202115418.GB12339@aemeltch-MOBL1> (raw)
In-Reply-To: <1322823396-5941-2-git-send-email-sancane@gmail.com>
He All,
On Fri, Dec 02, 2011 at 11:56:32AM +0100, Santiago Carot-Nemesio wrote:
> ---
> health/hdp_util.c | 171 +++++++++++++++++++++++++++--------------------------
> 1 files changed, 86 insertions(+), 85 deletions(-)
>
> diff --git a/health/hdp_util.c b/health/hdp_util.c
> index e62ed46..7a234c1 100644
> --- a/health/hdp_util.c
> +++ b/health/hdp_util.c
> @@ -362,24 +362,24 @@ static gboolean register_service_protocols(struct hdp_adapter *adapter,
> /* set l2cap information */
> sdp_uuid16_create(&l2cap_uuid, L2CAP_UUID);
> l2cap_list = sdp_list_append(NULL, &l2cap_uuid);
> - if (!l2cap_list) {
> + if (l2cap_list == NULL) {
Is this a really better way?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2011-12-02 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 10:56 Health Device Profile patches Santiago Carot-Nemesio
2011-12-02 10:56 ` [PATCH 1/5] hdp_util: Fix coding style issues Santiago Carot-Nemesio
2011-12-02 10:56 ` [PATCH 2/5] hdp_types: Fix unappropiated field type for dbus watcher id Santiago Carot-Nemesio
2011-12-02 10:56 ` [PATCH 3/5] hdp_util: Fix potential NULL pointer dereference Santiago Carot-Nemesio
2011-12-02 10:56 ` [PATCH 4/5] hdp_manager: Fix coding style issues Santiago Carot-Nemesio
2011-12-02 10:56 ` [PATCH 5/5] hdp: " Santiago Carot-Nemesio
2011-12-02 11:54 ` Andrei Emeltchenko [this message]
2011-12-08 12:41 ` Health Device Profile patches Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202115418.GB12339@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox