Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Syam Sidhardhan <syamsidhardh@gmail.com>
Cc: Syam Sidhardhan <s.syam@samsung.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix dbus reply memory leak
Date: Sun, 4 Dec 2011 22:55:41 +0200	[thread overview]
Message-ID: <20111204205541.GA3918@fusion.localdomain> (raw)
In-Reply-To: <4EDA85AA.3060400@gmail.com>

Hi Syam,

On Sun, Dec 04, 2011, Syam Sidhardhan wrote:
> >Your commit message uses the word leak in singular form but there are
> >multiple fixes in this patch, i.e. the commit message is misleading. In
> >this case I'd split the patch into four separate ones:
> >
> >telephony-maemo5: Fix D-Bus reply memory leaks
> >cups: Fix D-Bus reply memory leaks
> >agent: Fix D-Bus reply memory leaks
> >mpris-player: Fix D-Bus reply memory leaks
> >
> >Johan
> 
> Yes, you are correct. You can split it into multiple patches.
> Thanks in advance.

Maybe I was a bit unclear: I'm expecting *you* to do this split and
resend the patches. Thanks :)

Johan

  parent reply	other threads:[~2011-12-04 20:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 14:14 [PATCH 1/3] Fix dbus reply memory leak Syam Sidhardhan
2011-11-24 14:14 ` [PATCH 2/3] Remove unwanted GError* assignment to NULL Syam Sidhardhan
2011-12-02 11:18   ` Johan Hedberg
2011-12-02 11:25     ` Santiago Carot
2011-11-24 14:14 ` [PATCH 3/3] Send the Extended Error result code, if requested in the failure cases Syam Sidhardhan
2011-11-24 15:16   ` Syam Sidhardhan
2011-12-02 11:15 ` [PATCH 1/3] Fix dbus reply memory leak Johan Hedberg
2011-12-03 20:25   ` Syam Sidhardhan
2011-12-03 21:00     ` gene heskett
2011-12-04 20:55     ` Johan Hedberg [this message]
2011-12-05 15:20       ` Syam Sidhardhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111204205541.GA3918@fusion.localdomain \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=s.syam@samsung.com \
    --cc=syamsidhardh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox