From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] Implement SetProperty D-Bus method
Date: Wed, 7 Dec 2011 16:58:51 +0200 [thread overview]
Message-ID: <20111207145851.GA19842@x220> (raw)
In-Reply-To: <1321973388-16300-2-git-send-email-sancane@gmail.com>
Hi Santiago,
On Tue, Nov 22, 2011, Santiago Carot-Nemesio wrote:
> ---
> thermometer/thermometer.c | 118 +++++++++++++++++++++++++++++++++++++-------
> 1 files changed, 99 insertions(+), 19 deletions(-)
Is this patch set still valid? If so, could you resend it with proper
commit messages. "Implement SetProperty D-Bus method" is much too
generic. It'd be nice if you could start using the convention we've
tried to adopt where we add context dependent prefixes to the message
summaries. In this case "thermometer: Add SetProperty D-Bus method"
would have already given enough of context to not have to look at the
patch content to know what it does.
Johan
next prev parent reply other threads:[~2011-12-07 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 14:49 Health Thermometer Profile patches Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 1/6] Implement SetProperty D-Bus method Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 2/6] Confiure C.C.C descriptor during the thermometer configuration Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 3/6] Process measurements interval indication Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 4/6] Fix possible null pointer deference Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 5/6] Fix access to an invalid memory sector if time stamp is not supported Santiago Carot-Nemesio
2011-11-22 14:49 ` [PATCH 6/6] Use system types instead of GLIB ones Santiago Carot-Nemesio
2011-12-02 11:26 ` [PATCH 2/6] Confiure C.C.C descriptor during the thermometer configuration Johan Hedberg
2011-12-02 11:52 ` Santiago Carot
2011-12-02 15:41 ` Anderson Lizardo
2011-12-07 14:58 ` Johan Hedberg [this message]
2011-12-09 10:02 ` [PATCH 1/6] Implement SetProperty D-Bus method Santiago Carot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207145851.GA19842@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).