Linux bluetooth development
 help / color / mirror / Atom feed
From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Process Read Local AMP Info in hciemu
Date: Thu, 8 Dec 2011 10:32:02 +0200	[thread overview]
Message-ID: <20111208083200.GB28028@aemeltch-MOBL1> (raw)
In-Reply-To: <1323331911.1965.6.camel@aeonflux>

Hi Marcel,

On Thu, Dec 08, 2011 at 10:11:51AM +0200, Marcel Holtmann wrote:
> Hi Andrei,
> 
> > Add processing of Read Local AMP Info in hciemu, the values returned are
> > used to emulate AMP HCI.
> > ---
> >  test/hciemu.c |   34 ++++++++++++++++++++++++++++++++++
> >  1 files changed, 34 insertions(+), 0 deletions(-)
> > 
> > diff --git a/test/hciemu.c b/test/hciemu.c
> > index 38918f5..1022eb5 100644
> > --- a/test/hciemu.c
> > +++ b/test/hciemu.c
> > @@ -44,6 +44,7 @@
> >  #include <bluetooth/bluetooth.h>
> >  #include <bluetooth/hci.h>
> >  #include <bluetooth/hci_lib.h>
> > +#include <bluetooth/l2cap.h>
> >  
> >  #define VHCI_DEV		"/dev/vhci"
> >  
> > @@ -777,6 +778,35 @@ static void hci_info_param(uint16_t ocf, int plen, uint8_t *data)
> >  		break;
> >  	}
> >  }
> > +static void hci_status_param(uint16_t ocf, int plen, uint8_t *data)
> > +{
> > +	read_local_amp_info_rp ai;
> > +	uint8_t status;
> > +
> > +	const uint16_t ogf = OGF_STATUS_PARAM;
> > +
> > +	switch (ocf) {
> > +		case OCF_READ_LOCAL_AMP_INFO:
> 
> one too many indentation here.

will fix this. BTW: What do you think about current approach that in this
test tool I always reply for this AMP-specific command. Shall we have
command-line parameter for controller type?

Best regards 
Andrei Emeltchenko 

  reply	other threads:[~2011-12-08  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07 13:03 [PATCH 1/2] Process Read Local AMP Info in hciemu Emeltchenko Andrei
2011-12-07 13:03 ` [PATCH 2/2] Print features for AMP devices Emeltchenko Andrei
2011-12-08  8:11 ` [PATCH 1/2] Process Read Local AMP Info in hciemu Marcel Holtmann
2011-12-08  8:32   ` Emeltchenko Andrei [this message]
2011-12-08  8:41     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111208083200.GB28028@aemeltch-MOBL1 \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox