From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client
Date: Thu, 15 Dec 2011 13:54:05 +0200 [thread overview]
Message-ID: <20111215115405.GA9571@x220> (raw)
In-Reply-To: <20111215115009.GB8056@x220>
Hi,
On Thu, Dec 15, 2011, Johan Hedberg wrote:
> On Mon, Dec 12, 2011, Bartosz Szatkowski wrote:
> > + { "GetMessagesListing", "sa{ss}", "s", map_get_messages_listing,
> > + G_DBUS_METHOD_FLAG_ASYNC },
>
> The name should be GetMessageListing and not GetMessagesListing (the
> latter isn't really proper english).
And now I notice that the spec. actually uses the plural form (which
still sounds to me like strange English). All this fuss could have been
avoided if we had had a proper discussion of the API beforehand and had
the documentation in place before these patches.
Johan
next prev parent reply other threads:[~2011-12-15 11:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:31 [PATCH obexd 1/4] Add support for SetFolder in MAP client Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 2/4] Add simple helper for " Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 3/4] Add basic support for MAP folder listing Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client Bartosz Szatkowski
2011-12-15 11:50 ` Johan Hedberg
2011-12-15 11:54 ` Johan Hedberg [this message]
2011-12-15 11:56 ` Bartosz Szatkowski
2011-12-15 12:10 ` Johan Hedberg
2011-12-15 12:13 ` Johan Hedberg
2011-12-15 11:54 ` Bartosz Szatkowski
2011-12-15 12:17 ` Johan Hedberg
2011-12-15 12:45 ` Bartosz Szatkowski
2012-06-06 8:14 ` Luiz Augusto von Dentz
2012-06-06 9:19 ` Bartosz Szatkowski
2011-12-15 11:43 ` [PATCH obexd 1/4] Add support for SetFolder " Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215115405.GA9571@x220 \
--to=johan.hedberg@gmail.com \
--cc=bulislaw@linux.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).