From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/4] mcap_sync.c: Fix include paths
Date: Thu, 15 Dec 2011 13:59:42 +0200 [thread overview]
Message-ID: <20111215115942.GA9850@x220> (raw)
In-Reply-To: <1323857512-5626-2-git-send-email-sancane@gmail.com>
Hi Santiago,
On Wed, Dec 14, 2011, Santiago Carot-Nemesio wrote:
> ---
> health/mcap_sync.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/health/mcap_sync.c b/health/mcap_sync.c
> index 5545cea..e2d7715 100644
> --- a/health/mcap_sync.c
> +++ b/health/mcap_sync.c
> @@ -28,8 +28,8 @@
> #include <stdlib.h>
> #include <bluetooth/bluetooth.h>
> #include <bluetooth/l2cap.h>
> -#include "../src/adapter.h"
> -#include "../src/manager.h"
> +#include <adapter.h>
> +#include <manager.h>
> #include <sys/ioctl.h>
>
> #include "config.h"
There's more to fix here than this. config.h should come before anything
else (and should be inside a #ifdef HAVE_CONFIG_H) and we sort the libc
includes first, then dbus,glib,etc and finally the bluez internal
includes.
Johan
next prev parent reply other threads:[~2011-12-15 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 10:11 [PATCH 1/4] hdp.c: Delay ChannelConnected signal Santiago Carot-Nemesio
2011-12-14 10:11 ` [PATCH 2/4] mcap_sync.c: Fix include paths Santiago Carot-Nemesio
2011-12-14 10:11 ` [PATCH 3/4] hdp.c: " Santiago Carot-Nemesio
2011-12-14 10:11 ` [PATCH 4/4] hdp.c: Fix memory leak aborting data channel connections Santiago Carot-Nemesio
2011-12-15 11:59 ` Johan Hedberg [this message]
2011-12-15 12:57 ` [PATCH 2/4] mcap_sync.c: Fix include paths Santiago Carot
2011-12-15 14:15 ` [PATCH 1/4] hdp.c: Delay ChannelConnected signal Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215115942.GA9850@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).