From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Hemant Gupta <hemant.gupta@stericsson.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2] mgmt: Add support for Passkey handling
Date: Thu, 15 Dec 2011 14:20:06 +0200 [thread overview]
Message-ID: <20111215122005.GF15283@aemeltch-MOBL1> (raw)
In-Reply-To: <20111215120851.GA10113@x220>
Hi Johan,
On Thu, Dec 15, 2011 at 02:08:51PM +0200, Johan Hedberg wrote:
> Hi Hemant,
>
> On Thu, Dec 15, 2011, Hemant Gupta wrote:
> > @@ -218,7 +218,7 @@ struct mgmt_rp_user_confirm_reply {
> > #define MGMT_OP_USER_PASSKEY_REPLY 0x001C
> > struct mgmt_cp_user_passkey_reply {
> > bdaddr_t bdaddr;
> > - uint32_t passkey;
> > + __le32 passkey;
> > } __packed;
>
> Otherwise the patch looks ok but this change shouldn't be in it. __le32
> is only for the kernel side.
Minor comment related to debugging in general. We always allocate space
for bluetooth address string even when we do not use debug.
Best regards
Andrei Emeltchenko
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-12-15 12:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 11:54 [PATCHv2] mgmt: Add support for Passkey handling Hemant Gupta
2011-12-15 12:08 ` Johan Hedberg
2011-12-15 12:20 ` Andrei Emeltchenko [this message]
2011-12-15 13:47 ` Hemant Gupta
2011-12-15 13:56 ` Johan Hedberg
2011-12-15 13:59 ` Hemant Gupta
2011-12-15 14:09 ` Johan Hedberg
2011-12-15 14:10 ` Hemant Gupta
2011-12-15 14:09 ` Hemant Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215122005.GF15283@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=hemant.gupta@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox