linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <padovan@profusion.mobi>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com,
	ulrik.lauren@stericsson.com, henrik.possung@stericsson.com
Subject: Re: [PATCH] Bluetooth: Fix race condition between RFCOMM and L2CAP
Date: Sun, 18 Dec 2011 21:33:18 -0200	[thread overview]
Message-ID: <20111218233318.GF2621@joana> (raw)
In-Reply-To: <1320844340-1966-2-git-send-email-andrzej.kaczmarek@tieto.com>

Hi Andrzej,

* Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com> [2011-11-09 14:12:20 +0100]:

> Sometimes when RFCOMM creates underlying L2CAP socket it happens that
> rfcomm_security_cfm is called before DLC is linked to session thus
> reference count for session struct is 0. As a result rfcomm_session_put
> will close session and connection will not be completed.
> 
> __rfcomm_dlc_open will now hold reference to rfcomm_session until DLC
> is linked to session to prevent the above from happening.
> 
> Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
> ---
>  net/bluetooth/rfcomm/core.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)

Can you check if this issue still happens after the workqueue patches. Those
kinds of issue in RFCOMM should be fixed by now.

	Gustavo

  reply	other threads:[~2011-12-18 23:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09 13:12 [PATCH] Race condition between RFCOMM and L2CAP Andrzej Kaczmarek
2011-11-09 13:12 ` [PATCH] Bluetooth: Fix race " Andrzej Kaczmarek
2011-12-18 23:33   ` Gustavo Padovan [this message]
2011-11-21  8:40 ` [PATCH] Race " Andrzej Kaczmarek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111218233318.GF2621@joana \
    --to=padovan@profusion.mobi \
    --cc=andrzej.kaczmarek@tieto.com \
    --cc=henrik.possung@stericsson.com \
    --cc=kanak.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=ulrik.lauren@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).