* [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth
@ 2011-12-24 12:01 Albert Pool
2011-12-27 16:03 ` Gustavo Padovan
0 siblings, 1 reply; 6+ messages in thread
From: Albert Pool @ 2011-12-24 12:01 UTC (permalink / raw)
To: marcel, padovan; +Cc: linux-bluetooth
Add USB ID of HP's Broadcom BCM2035 Bluetooth 03f0:011d
>From usb-devices:
T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=03f0 ProdID=011d Rev=00.17
S: Manufacturer=Broadcom
S: Product=HP integrated Bluetooth module
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
Signed-off-by: Albert Pool <albertpool@solcon.nl>
- - -
It now pairs to my laptop (which has the other HP device 03f0:171d) but does not yet pair to my desktop with 0a12:0001 Cambridge Silicon Radio dongle.
I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it often failed to enable the device.
This patch is at least an improvement as it used to pair to nothing at all. Perhaps anyone knows a better solution with which it pairs to everything just like on Windows XP?
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
{ USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
{ USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
- /* HP laptop with Broadcom chip */
+ /* HP laptops with Broadcom chip */
+ { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
{ USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
/* Dell laptop with Broadcom chip */
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth
2011-12-24 12:01 [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth Albert Pool
@ 2011-12-27 16:03 ` Gustavo Padovan
2011-12-27 17:54 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2011-12-27 16:03 UTC (permalink / raw)
To: Albert Pool; +Cc: marcel, linux-bluetooth
Hi Albert,
* Albert Pool <albertpool@solcon.nl> [2011-12-24 13:01:04 +0100]:
> Add USB ID of HP's Broadcom BCM2035 Bluetooth 03f0:011d
>
> From usb-devices:
> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=03f0 ProdID=011d Rev=00.17
> S: Manufacturer=Broadcom
> S: Product=HP integrated Bluetooth module
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
>
> Signed-off-by: Albert Pool <albertpool@solcon.nl>
> - - -
> It now pairs to my laptop (which has the other HP device 03f0:171d) but does not yet pair to my desktop with 0a12:0001 Cambridge Silicon Radio dongle.
> I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it often failed to enable the device.
> This patch is at least an improvement as it used to pair to nothing at all. Perhaps anyone knows a better solution with which it pairs to everything just like on Windows XP?
>
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
> { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
> { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
>
> - /* HP laptop with Broadcom chip */
> + /* HP laptops with Broadcom chip */
> + { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
> { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
>
> /* Dell laptop with Broadcom chip */
Please fix this and resend. Also add "Bluetooth: " to your commit subject.
Applying: Add USB ID of HP's Broadcom BCM2035 Bluetooth
/home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:8: trailing whitespace.
/* HP laptops with Broadcom chip */
/home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:9: trailing whitespace.
{ USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
error: drivers/bluetooth/btusb.c : does not exist in index
Patch failed at 0001 Add USB ID of HP's Broadcom BCM2035 Bluetooth
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth
2011-12-27 16:03 ` Gustavo Padovan
@ 2011-12-27 17:54 ` Marcel Holtmann
2011-12-27 19:02 ` Albert Pool
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2011-12-27 17:54 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Albert Pool, linux-bluetooth
Hi Gustavo,
> * Albert Pool <albertpool@solcon.nl> [2011-12-24 13:01:04 +0100]:
>
> > Add USB ID of HP's Broadcom BCM2035 Bluetooth 03f0:011d
> >
> > From usb-devices:
> > T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
> > D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=03f0 ProdID=011d Rev=00.17
> > S: Manufacturer=Broadcom
> > S: Product=HP integrated Bluetooth module
> > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> > I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
> >
> > Signed-off-by: Albert Pool <albertpool@solcon.nl>
> > - - -
> > It now pairs to my laptop (which has the other HP device 03f0:171d) but does not yet pair to my desktop with 0a12:0001 Cambridge Silicon Radio dongle.
> > I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it often failed to enable the device.
> > This patch is at least an improvement as it used to pair to nothing at all. Perhaps anyone knows a better solution with which it pairs to everything just like on Windows XP?
> >
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
> > { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
> > { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
> >
> > - /* HP laptop with Broadcom chip */
> > + /* HP laptops with Broadcom chip */
> > + { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
> > { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
> >
> > /* Dell laptop with Broadcom chip */
>
> Please fix this and resend. Also add "Bluetooth: " to your commit subject.
actually I am not convinced this is the right fix. Adding random driver
flags and hoping that it makes them works is a bad idea. The BCM92035
was one specific behavior to switch HID proxy mode into working dongle,
but that is ancient behavior. These days just HCI_Reset is enough for
Broadcom dongles.
Also the fact that it still does not complete work makes me highly
suspicious that this fix is actually wrong. And without having seen the
hcidump's for the failing pairing, I would not bother here at all.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth
2011-12-27 17:54 ` Marcel Holtmann
@ 2011-12-27 19:02 ` Albert Pool
2011-12-27 19:07 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: Albert Pool @ 2011-12-27 19:02 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Gustavo Padovan, linux-bluetooth
Hi Marcel,
I think the desktop's dongle might be to blame when the old laptop fails
to pair to that. I've had more Bluetooth problems on the desktop, e.g.
being unable to remove paired devices of the dongle's previous owner.
The Bluetooth sticker on the downside of the old laptop lists:
Broadcom BCM92035NMD CE 370653-003
Universal Scientific Industrial
Contains FCC ID: QDS-BRCM1009
IC: 4324A-BRCM1009
SCT: RCPBRBC04-389
CMI ID: 2003DJ1517
CNC 16-3215
along with a lot of text in other languages.
Other BCM2035 USB ID's have BTUSB_WRONG_SCO_MTU but that option really
does not work reliably on this old laptop.
Everything's now working with Linux on this HP Compaq nc6120, except
Bluetooth.
Regards,
Albert
Op dinsdag 27-12-2011 om 09:54 uur [tijdzone -0800], schreef Marcel
Holtmann:
> Hi Gustavo,
>
> > * Albert Pool <albertpool@solcon.nl> [2011-12-24 13:01:04 +0100]:
> >
> > > Add USB ID of HP's Broadcom BCM2035 Bluetooth 03f0:011d
> > >
> > > From usb-devices:
> > > T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
> > > D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> > > P: Vendor=03f0 ProdID=011d Rev=00.17
> > > S: Manufacturer=Broadcom
> > > S: Product=HP integrated Bluetooth module
> > > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> > > I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> > > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
> > >
> > > Signed-off-by: Albert Pool <albertpool@solcon.nl>
> > > - - -
> > > It now pairs to my laptop (which has the other HP device 03f0:171d) but does not yet pair to my desktop with 0a12:0001 Cambridge Silicon Radio dongle.
> > > I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it often failed to enable the device.
> > > This patch is at least an improvement as it used to pair to nothing at all. Perhaps anyone knows a better solution with which it pairs to everything just like on Windows XP?
> > >
> > > --- a/drivers/bluetooth/btusb.c
> > > +++ b/drivers/bluetooth/btusb.c
> > > @@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
> > > { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
> > > { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
> > >
> > > - /* HP laptop with Broadcom chip */
> > > + /* HP laptops with Broadcom chip */
> > > + { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
> > > { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
> > >
> > > /* Dell laptop with Broadcom chip */
> >
> > Please fix this and resend. Also add "Bluetooth: " to your commit subject.
>
> actually I am not convinced this is the right fix. Adding random driver
> flags and hoping that it makes them works is a bad idea. The BCM92035
> was one specific behavior to switch HID proxy mode into working dongle,
> but that is ancient behavior. These days just HCI_Reset is enough for
> Broadcom dongles.
>
> Also the fact that it still does not complete work makes me highly
> suspicious that this fix is actually wrong. And without having seen the
> hcidump's for the failing pairing, I would not bother here at all.
>
> Regards
>
> Marcel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth
2011-12-27 19:02 ` Albert Pool
@ 2011-12-27 19:07 ` Marcel Holtmann
2011-12-27 20:30 ` [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth [SOLVED] Albert Pool
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2011-12-27 19:07 UTC (permalink / raw)
To: Albert Pool; +Cc: Gustavo Padovan, linux-bluetooth
Hi Albert,
please refrain from top-posting on this mailing list.
> I think the desktop's dongle might be to blame when the old laptop fails
> to pair to that. I've had more Bluetooth problems on the desktop, e.g.
> being unable to remove paired devices of the dongle's previous owner.
>
> The Bluetooth sticker on the downside of the old laptop lists:
> Broadcom BCM92035NMD CE 370653-003
> Universal Scientific Industrial
> Contains FCC ID: QDS-BRCM1009
> IC: 4324A-BRCM1009
> SCT: RCPBRBC04-389
> CMI ID: 2003DJ1517
> CNC 16-3215
> along with a lot of text in other languages.
>
> Other BCM2035 USB ID's have BTUSB_WRONG_SCO_MTU but that option really
> does not work reliably on this old laptop.
The need for WRONG_SCO_MTU detail can be easily determined. Check the
output of hciconfig without this quirk. If the SCO MTU essentially shows
0 values, then you need it.
But then again, you are just randomly adding quirks without
understanding what they are for. This makes me worry a lot.
Are you actually running a recent 3.x kernel or are you just using an
outdated kernel?
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth [SOLVED]
2011-12-27 19:07 ` Marcel Holtmann
@ 2011-12-27 20:30 ` Albert Pool
0 siblings, 0 replies; 6+ messages in thread
From: Albert Pool @ 2011-12-27 20:30 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Gustavo Padovan, linux-bluetooth
Op dinsdag 27-12-2011 om 11:07 uur [tijdzone -0800], schreef Marcel
Holtmann:
> Hi Albert,
>
> please refrain from top-posting on this mailing list.
>
> The need for WRONG_SCO_MTU detail can be easily determined. Check the
> output of hciconfig without this quirk. If the SCO MTU essentially shows
> 0 values, then you need it.
>
> But then again, you are just randomly adding quirks without
> understanding what they are for. This makes me worry a lot.
>
> Are you actually running a recent 3.x kernel or are you just using an
> outdated kernel?
>
> Regards
>
> Marcel
>
>
Hi Marcel (and Gustavo),
You were right. I was using and old kernel, 2.6.38, and picking the
fixes from other Broadcom hardware to get Bluetooth working on that
kernel, and applying those fixes to the btusb module of compat-wireless.
I wasn't aware of hciconfig.
Using a recent btusb module (compat-wireless 2011-12-18) without any
patch, it's magically working 'just fine'. And it pairs to my desktop.
It still amazes me how some Broadcom 2035's need a patch while others
don't. I assumed that this Broadcom 2035 would need a patch as well, so
I hadn't even tried getting a recent kernel or module.
(Perhaps it would be a good idea to get a more recent btusb module on my
desktop as well...)
Anyway, thanks for pointing me into the right direction. I'm sorry for
disturbing you and your mailing list with what turned out to be
nonsense. I've learnt a lot about Bluetooth on Linux from this
adventure.
Regards,
Albert
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-27 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-24 12:01 [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth Albert Pool
2011-12-27 16:03 ` Gustavo Padovan
2011-12-27 17:54 ` Marcel Holtmann
2011-12-27 19:02 ` Albert Pool
2011-12-27 19:07 ` Marcel Holtmann
2011-12-27 20:30 ` [PATCH v3] Add USB ID of HP's Broadcom BCM2035 Bluetooth [SOLVED] Albert Pool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).