From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Andre Guedes <andre.guedes@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed()
Date: Tue, 3 Jan 2012 00:48:22 +0200 [thread overview]
Message-ID: <20120102224822.GA7603@fusion.localdomain> (raw)
In-Reply-To: <1325543108.1965.403.camel@aeonflux>
On Mon, Jan 02, 2012, Marcel Holtmann wrote:
> > Stop Discovery Command Status Event should use mgmt status code.
> >
> > Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> > ---
> > net/bluetooth/mgmt.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> > index 2540944..fb0b15e 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -2756,7 +2756,7 @@ int mgmt_stop_discovery_failed(struct hci_dev *hdev, u8 status)
> > if (!cmd)
> > return -ENOENT;
> >
> > - err = cmd_status(cmd->sk, hdev->id, cmd->opcode, status);
> > + err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status));
> > mgmt_pending_remove(cmd);
>
> patch does look reasonable to me, but I am not this is the expected
> behavior. I leave this up to Johan to ACK or NAK.
Looks good to me.
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
next prev parent reply other threads:[~2012-01-02 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 19:50 [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed() Andre Guedes
2012-01-02 22:25 ` Marcel Holtmann
2012-01-02 22:48 ` Johan Hedberg [this message]
2012-01-03 0:44 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102224822.GA7603@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox