linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Bluetooth: invert locking order in connect path
@ 2012-01-03 14:44 Dan Carpenter
  2012-01-03 19:10 ` Gustavo Padovan
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-01-03 14:44 UTC (permalink / raw)
  To: Gustavo F. Padovan; +Cc: linux-bluetooth

Hi Gustavo,

You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
invert locking order in connect path" did you?  It causes a Sparse
warning.

include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
a definition

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bluetooth: invert locking order in connect path
  2012-01-03 14:44 Bluetooth: invert locking order in connect path Dan Carpenter
@ 2012-01-03 19:10 ` Gustavo Padovan
  2012-01-11 15:01   ` Johan Hedberg
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Padovan @ 2012-01-03 19:10 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: linux-bluetooth

Hi Dan,

* Dan Carpenter <dan.carpenter@oracle.com> [2012-01-03 17:44:33 +0300]:

> Hi Gustavo,
> 
> You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
> invert locking order in connect path" did you?  It causes a Sparse
> warning.
> 
> include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
> a definition

Indeed, I'll fix it.

	Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bluetooth: invert locking order in connect path
  2012-01-03 19:10 ` Gustavo Padovan
@ 2012-01-11 15:01   ` Johan Hedberg
  0 siblings, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2012-01-11 15:01 UTC (permalink / raw)
  To: Dan Carpenter, linux-bluetooth

Hi,

On Tue, Jan 03, 2012, Gustavo Padovan wrote:
> * Dan Carpenter <dan.carpenter@oracle.com> [2012-01-03 17:44:33 +0300]:
> 
> > Hi Gustavo,
> > 
> > You didn't mean to mark the function inline in 03a001948166 "Bluetooth:
> > invert locking order in connect path" did you?  It causes a Sparse
> > warning.
> > 
> > include/net/bluetooth/l2cap.h:837:30 error: marked inline, but without
> > a definition
> 
> Indeed, I'll fix it.

I didn't see the patch for this anywhere so I did it myself and got an
ack from Marcel. It's now part of my bluetooth-next tree.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-11 15:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 14:44 Bluetooth: invert locking order in connect path Dan Carpenter
2012-01-03 19:10 ` Gustavo Padovan
2012-01-11 15:01   ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).