From: Johan Hedberg <johan.hedberg@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi,
marcel@holtmann.org, Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] net: bluetooth: Fix 'enable_hs' type
Date: Tue, 10 Jan 2012 23:00:42 +0200 [thread overview]
Message-ID: <20120110210042.GA7954@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1326227630-2556-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On Tue, Jan 10, 2012, Fabio Estevam wrote:
> Fix the following build warning:
>
> CC [M] net/bluetooth/hci_core.o
> net/bluetooth/hci_core.c: In function ‘__check_enable_hs’:
> net/bluetooth/hci_core.c:2587: warning: return from incompatible pointer type
>
> module_param in hci_core.c passes 'enable_hs' as bool format, so fix this variable definition type.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/net/bluetooth/hci.h | 2 +-
> net/bluetooth/hci_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
The patch has been applied to my bluetooth-next tree. Don't you get the
same warning for enable_mgmt and enable_le as well? Those seem to be
declared in a similar manner.
Johan
next prev parent reply other threads:[~2012-01-10 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 20:33 [PATCH] net: bluetooth: Fix 'enable_hs' type Fabio Estevam
2012-01-10 20:44 ` Marcel Holtmann
2012-01-10 21:00 ` Johan Hedberg [this message]
2012-01-10 21:08 ` Fabio Estevam
2012-01-10 21:31 ` Johan Hedberg
2012-01-10 22:21 ` Fabio Estevam
2012-01-10 22:48 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110210042.GA7954@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox