From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, skrovvid@codeaurora.org
Subject: Re: As long as we're adding to the Device Connected mgmt event...
Date: Tue, 17 Jan 2012 01:14:23 +0200 [thread overview]
Message-ID: <20120116231423.GA13647@x220.P-661HNU-F1> (raw)
In-Reply-To: <alpine.DEB.2.02.1201160807170.29809@mathewm-linux>
Hi Mat,
On Mon, Jan 16, 2012, Mat Martineau wrote:
> >>>I noticed your recent bluez.git commit that modifies the Device
> >>>Connected event. Would it also make sense to add the results of the
> >>>READ_REMOTE_VERSION command?
> >>>
> >>>lmp_ver
> >>>manufacturer
> >>>lmp_subver
> >>>
> >>>This information was captured in bluetoothd when using hciops, but
> >>>has so far been missing with mgmtops.
> >>
> >>Do you have a real use-case for it? It'd expect that info to be at most
> >>useful to the kernel side but not so much for user-space. FWIW, we came
> >>to the conclusion with Marcel that a better approach with this
> >>mgmt_ev_device_connected is to encode both the class and the name as an
> >>EIR blob. We'll also do that for the class that's currently as a
> >>separate parameter in mgmt_ev_device_found. This simplifies the
> >>structure of both events and also allows for future extensibility.
> >
> >in addition, these information are purely debugging details and I think
> >it would be better to use sysfs or debugfs for it.
>
> The use case involves checking the remote LMP version to figure out
> if the remote device supports EDR, to get a rough estimate of
> available bandwidth. Lower bandwidth devices can then use different
> settings at the profile or application layer.
If something like that is really needed then I think some sort of a
socket option might make more sense, i.e. the application could call
getsockopt (or some higher level wrapper like BtIO) to figure this out.
In any case it's not enough for the remote device to support EDR if the
local device isn't capable of it.
Johan
next prev parent reply other threads:[~2012-01-16 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 20:08 As long as we're adding to the Device Connected mgmt event Mat Martineau
2012-01-15 11:03 ` Johan Hedberg
2012-01-16 6:45 ` Marcel Holtmann
2012-01-16 16:26 ` Mat Martineau
2012-01-16 23:14 ` Johan Hedberg [this message]
2012-01-17 7:52 ` Marcel Holtmann
2012-01-17 7:39 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116231423.GA13647@x220.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathewm@codeaurora.org \
--cc=skrovvid@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox