From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd v2 1/4] MAP: Implementation of MAP AP core functions
Date: Wed, 18 Jan 2012 14:13:37 +0200 [thread overview]
Message-ID: <20120118121337.GB6655@x220> (raw)
In-Reply-To: <1326461618-26864-1-git-send-email-lkslawek@gmail.com>
Hi Slawek,
On Fri, Jan 13, 2012, Slawomir Bochenski wrote:
> + union {
> + uint32_t val32u;
> + uint16_t val16u;
> + uint8_t val8u;
> + char *valstr;
> + };
To keep consistent with some other places in BlueZ code, could you do
this as:
union {
uint32_t u32;
uint16_t u16;
uint8_t u8;
char *str;
} val;
After which you'd access these as entry->val.u32, etc.
Johan
prev parent reply other threads:[~2012-01-18 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 13:33 [PATCH obexd v2 1/4] MAP: Implementation of MAP AP core functions Slawomir Bochenski
2012-01-13 13:33 ` [PATCH obexd v2 2/4] map_ap.c: Add implementation for map_ap_set_* Slawomir Bochenski
2012-01-13 13:33 ` [PATCH obexd v2 3/4] map_ap.c: Add implementation for map_ap_decode() Slawomir Bochenski
2012-01-13 13:33 ` [PATCH obexd v2 4/4] map_ap.c: Add dumping of map_ap_t after decoding Slawomir Bochenski
2012-01-18 12:13 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118121337.GB6655@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lkslawek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).