linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: Add alloc_skb chan operator
Date: Mon, 23 Jan 2012 11:09:30 +0200	[thread overview]
Message-ID: <20120123090930.GC8800@x220> (raw)
In-Reply-To: <20120123090046.GB8800@x220>

Hi Andrei,

On Mon, Jan 23, 2012, Johan Hedberg wrote:
> On Thu, Jan 19, 2012, Emeltchenko Andrei wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > 
> > Add channel-specific skb allocation method
> > 
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > ---
> >  include/net/bluetooth/l2cap.h |    3 +++
> >  net/bluetooth/l2cap_core.c    |   22 +++++++++++++++-------
> >  net/bluetooth/l2cap_sock.c    |    9 +++++++++
> >  3 files changed, 27 insertions(+), 7 deletions(-)
> 
> Applied. Thanks.

Actually I had to remove this commit (hopefully nobody pulled from my
tree meanwhile). It introduces the following compiler warning:

net/bluetooth/l2cap_core.c: In function 'l2cap_skbuff_fromiovec':
net/bluetooth/l2cap_core.c:1523:15: warning: unused variable 'sk' [-Wunused-variable]

Please fix and resend (I think you can keep the ack from Marcel).

Johan

  reply	other threads:[~2012-01-23  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 13:13 [RFC] Bluetooth: Add alloc_skb chan operator Emeltchenko Andrei
2012-01-19 13:30 ` Marcel Holtmann
2012-01-23  9:00 ` Johan Hedberg
2012-01-23  9:09   ` Johan Hedberg [this message]
2012-01-23  9:13     ` Emeltchenko Andrei
2012-01-23  9:24       ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120123090930.GC8800@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).