Re: [RFC] Bluetooth: Add alloc_skb chan operator

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Andrei,

On Mon, Jan 23, 2012, Emeltchenko Andrei wrote:
> > On Mon, Jan 23, 2012, Johan Hedberg wrote:
> > > On Thu, Jan 19, 2012, Emeltchenko Andrei wrote:
> > > > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > > 
> > > > Add channel-specific skb allocation method
> > > > 
> > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > > ---
> > > >  include/net/bluetooth/l2cap.h |    3 +++
> > > >  net/bluetooth/l2cap_core.c    |   22 +++++++++++++++-------
> > > >  net/bluetooth/l2cap_sock.c    |    9 +++++++++
> > > >  3 files changed, 27 insertions(+), 7 deletions(-)
> > > 
> > > Applied. Thanks.
> > 
> > Actually I had to remove this commit (hopefully nobody pulled from my
> > tree meanwhile). It introduces the following compiler warning:
> > 
> > net/bluetooth/l2cap_core.c: In function 'l2cap_skbuff_fromiovec':
> > net/bluetooth/l2cap_core.c:1523:15: warning: unused variable 'sk' [-Wunused-variable]
> > 
> > Please fix and resend (I think you can keep the ack from Marcel).
> 
> Sorry, I've noticed it also and sent last week v2.

Yep, found the v2 now and applied it. If you want to avoid this kind of
confusion in the future please also reply to the original thread in
addition to sending the new version (especially if the original thread
has no indication that there's a new patch on the way).

Johan