* [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add()
@ 2012-01-30 12:22 Andre Guedes
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andre Guedes @ 2012-01-30 12:22 UTC (permalink / raw)
To: linux-bluetooth
This function is called in process context only, so it should use
GFP_KERNEL to allocate memory.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/hci_conn.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index eae7a53..9ec7b8e 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -373,7 +373,7 @@ struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst)
BT_DBG("%s dst %s", hdev->name, batostr(dst));
- conn = kzalloc(sizeof(struct hci_conn), GFP_ATOMIC);
+ conn = kzalloc(sizeof(struct hci_conn), GFP_KERNEL);
if (!conn)
return NULL;
--
1.7.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create()
2012-01-30 12:22 [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Andre Guedes
@ 2012-01-30 12:22 ` Andre Guedes
2012-01-30 16:36 ` Ulisses Furquim
2012-01-30 18:24 ` Marcel Holtmann
2012-01-30 18:23 ` [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Marcel Holtmann
2012-01-30 19:08 ` Johan Hedberg
2 siblings, 2 replies; 6+ messages in thread
From: Andre Guedes @ 2012-01-30 12:22 UTC (permalink / raw)
To: linux-bluetooth
This function is called in process context only, so it should use
GFP_KERNEL to allocate memory.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/hci_conn.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 9ec7b8e..7b38a0b 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -945,7 +945,7 @@ struct hci_chan *hci_chan_create(struct hci_conn *conn)
BT_DBG("%s conn %p", hdev->name, conn);
- chan = kzalloc(sizeof(struct hci_chan), GFP_ATOMIC);
+ chan = kzalloc(sizeof(struct hci_chan), GFP_KERNEL);
if (!chan)
return NULL;
--
1.7.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create()
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
@ 2012-01-30 16:36 ` Ulisses Furquim
2012-01-30 18:24 ` Marcel Holtmann
1 sibling, 0 replies; 6+ messages in thread
From: Ulisses Furquim @ 2012-01-30 16:36 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
On Mon, Jan 30, 2012 at 10:22 AM, Andre Guedes
<andre.guedes@openbossa.org> wrote:
> This function is called in process context only, so it should use
> GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 9ec7b8e..7b38a0b 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -945,7 +945,7 @@ struct hci_chan *hci_chan_create(struct hci_conn *conn)
>
> BT_DBG("%s conn %p", hdev->name, conn);
>
> - chan = kzalloc(sizeof(struct hci_chan), GFP_ATOMIC);
> + chan = kzalloc(sizeof(struct hci_chan), GFP_KERNEL);
> if (!chan)
> return NULL;
>
The two patches to use GFP_KERNEL seem ok to me and that's the path
Padovan and Marcel wanted to go, of course, now that we run in process
context.
Best regards,
--
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add()
2012-01-30 12:22 [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Andre Guedes
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
@ 2012-01-30 18:23 ` Marcel Holtmann
2012-01-30 19:08 ` Johan Hedberg
2 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2012-01-30 18:23 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
> This function is called in process context only, so it should use
> GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create()
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
2012-01-30 16:36 ` Ulisses Furquim
@ 2012-01-30 18:24 ` Marcel Holtmann
1 sibling, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2012-01-30 18:24 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
> This function is called in process context only, so it should use
> GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add()
2012-01-30 12:22 [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Andre Guedes
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
2012-01-30 18:23 ` [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Marcel Holtmann
@ 2012-01-30 19:08 ` Johan Hedberg
2 siblings, 0 replies; 6+ messages in thread
From: Johan Hedberg @ 2012-01-30 19:08 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
On Mon, Jan 30, 2012, Andre Guedes wrote:
> This function is called in process context only, so it should use
> GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Both patches have been applied to my bluetooth-next tree. Thanks.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-30 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 12:22 [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Andre Guedes
2012-01-30 12:22 ` [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create() Andre Guedes
2012-01-30 16:36 ` Ulisses Furquim
2012-01-30 18:24 ` Marcel Holtmann
2012-01-30 18:23 ` [PATCH 1/2] Bluetooth: Use GFP_KERNEL in hci_conn_add() Marcel Holtmann
2012-01-30 19:08 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).