From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RESEND 1/3] Bluetooth: Use cancel_work instead of cancel_work_sync
Date: Tue, 31 Jan 2012 15:02:43 +0200 [thread overview]
Message-ID: <20120131130242.GB7660@aemeltch-MOBL1> (raw)
In-Reply-To: <CACJA=fWD6wOnNT4jFvGQAP3hRo0AKWAoiZTHZsfmGvp+6JdxOg@mail.gmail.com>
Hi Andre,
On Tue, Jan 31, 2012 at 09:31:45AM -0300, Andre Guedes wrote:
> > - cancel_delayed_work_sync(&conn->disc_work);
> > + cancel_delayed_work(&conn->disc_work);
>
> I'm afraid we must use _sync variant here. disc_work is not supposed to
> be running after hci_conn is deleted.
>
> BTW, I believe we already addressed this issue in patches [PATCH 1/2]
> Bluetooth: Fix potential deadlock and [PATCH 2/2] Bluetooth: Remove
> unneeded locking. These patches are now pushed upstream. Could you
I will check those patches from upstream and let you know.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-01-31 13:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 8:43 [RESEND 0/3] Fixes kernel crashes and warnings Emeltchenko Andrei
2012-01-31 8:43 ` [RESEND 1/3] Bluetooth: Use cancel_work instead of cancel_work_sync Emeltchenko Andrei
2012-01-31 12:31 ` Andre Guedes
2012-01-31 13:02 ` Emeltchenko Andrei [this message]
2012-01-31 15:11 ` Marcel Holtmann
2012-01-31 15:41 ` Ulisses Furquim
2012-01-31 15:58 ` Marcel Holtmann
2012-01-31 17:49 ` Ulisses Furquim
2012-02-01 13:32 ` Emeltchenko Andrei
2012-02-01 15:53 ` Marcel Holtmann
2012-02-02 8:34 ` Emeltchenko Andrei
2012-01-31 15:07 ` Marcel Holtmann
2012-01-31 8:43 ` [RESEND 2/3] Bluetooth: Use list _safe deleting from conn_hash_list Emeltchenko Andrei
2012-01-31 15:07 ` Marcel Holtmann
2012-01-31 8:43 ` [RESEND 3/3] Bluetooth: Use list _safe deleting from conn chan_list Emeltchenko Andrei
2012-01-31 15:08 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131130242.GB7660@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox