From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] src/obex.h: Include stdint.h
Date: Fri, 3 Feb 2012 13:22:14 -0800 [thread overview]
Message-ID: <20120203212214.GA31587@x220.globalsuite.net> (raw)
In-Reply-To: <1328266762-23552-1-git-send-email-lkslawek@gmail.com>
Hi Slawek,
On Fri, Feb 03, 2012, Slawomir Bochenski wrote:
> ---
> src/obex.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/obex.h b/src/obex.h
> index 7f07fd2..95e9c4e 100644
> --- a/src/obex.h
> +++ b/src/obex.h
> @@ -22,6 +22,8 @@
> *
> */
>
> +#include <stdint.h>
> +
> #define OBJECT_SIZE_UNKNOWN -1
> #define OBJECT_SIZE_DELETE -2
This file also contains GLib usage but there's no GLib include there.
Either *all* includes should be there or *none* should be there (i.e.
expect the .c files to include the dependencies). In this case I'd just
add the stdint include to whatever file had it missing (which one was it
btw?).
Johan
prev parent reply other threads:[~2012-02-03 21:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 10:59 [PATCH obexd] src/obex.h: Include stdint.h Slawomir Bochenski
2012-02-03 21:22 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203212214.GA31587@x220.globalsuite.net \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lkslawek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).