From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Date: Mon, 6 Feb 2012 10:43:21 +0200
From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-bluetooth@vger.kernel.org,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] l2cap_chan_connect() shouldn't be inlined
Message-ID: <20120206084319.GB12455@aemeltch-MOBL1>
References: <20120205062105.GZ23916@ZenIV.linux.org.uk>
 <1328469130.2062.77.camel@aeonflux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1328469130.2062.77.camel@aeonflux>
Sender: netdev-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi all,

On Sun, Feb 05, 2012 at 11:12:10AM -0800, Marcel Holtmann wrote:
> Hi Al,
> 
> > For one thing, it's big.  For another, the only caller is in a different
> > file anyway...
> > 
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > 
> > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> > index 68f5891..124f7cf 100644
> > --- a/include/net/bluetooth/l2cap.h
> > +++ b/include/net/bluetooth/l2cap.h
> > @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan,  __u16 scid);
> >  struct l2cap_chan *l2cap_chan_create(struct sock *sk);
> >  void l2cap_chan_close(struct l2cap_chan *chan, int reason);
> >  void l2cap_chan_destroy(struct l2cap_chan *chan);
> > -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> > +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> >  								bdaddr_t *dst);
> 
> I have no idea on how that happened, but you are fully correct this is
> pointless.
> 
> Acked-by: Marcel Holtmann <marcel@holtmann.org>

Similar patch has been already applied a month ago to our bluetooth tree

commit 79aa1a3322cfa65199a0d87eacd41bd1fbc33a1d
Author: Johan Hedberg <johan.hedberg@intel.com>
Date:   Sun Jan 8 22:51:16 2012 +0200

Best regards 
Andrei Emeltchenko