From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] attrib-server: Fix memory leak attaching attribute channels
Date: Wed, 8 Feb 2012 10:21:25 +0200 [thread overview]
Message-ID: <20120208082123.GA5917@aemeltch-MOBL1> (raw)
In-Reply-To: <1328621205-14440-1-git-send-email-sancane@gmail.com>
Hi Santiago,
On Tue, Feb 07, 2012 at 02:26:44PM +0100, Santiago Carot-Nemesio wrote:
> Channel is not being released when the channel is attached over
> an uninitialized GATT server.
> ---
> src/attrib-server.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/src/attrib-server.c b/src/attrib-server.c
> index 2995167..e51f695 100644
> --- a/src/attrib-server.c
> +++ b/src/attrib-server.c
> @@ -1020,8 +1020,14 @@ guint attrib_channel_attach(GAttrib *attrib, gboolean out)
> }
>
> server = find_gatt_server(&channel->src);
> - if (server == NULL)
> + if (server == NULL) {
> + char src[18];
Don't we have a good define for this magic number? I saw it in several
places.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-02-08 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 13:26 [PATCH 1/2] attrib-server: Fix memory leak attaching attribute channels Santiago Carot-Nemesio
2012-02-07 13:37 ` [PATCH 2/2] attrib-server: Fix bad error message Santiago Carot-Nemesio
2012-02-08 8:21 ` Andrei Emeltchenko [this message]
2012-02-08 8:47 ` [PATCH 1/2] attrib-server: Fix memory leak attaching attribute channels Santiago Carot
2012-02-09 10:45 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2012-02-07 9:33 Santiago Carot-Nemesio
2012-02-07 10:53 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208082123.GA5917@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).