From: Szymon Janc <szymon.janc@tieto.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Do not dereference zero sk
Date: Tue, 14 Feb 2012 14:27:21 +0100 [thread overview]
Message-ID: <201202141427.22053.szymon.janc@tieto.com> (raw)
In-Reply-To: <1329225150.28848.74.camel@aeonflux>
Hi,
> > @@ -795,7 +795,7 @@ static void l2cap_sock_kill(struct sock *sk)
> > static int l2cap_sock_shutdown(struct socket *sock, int how)
> > {
> > struct sock *sk = sock->sk;
> > - struct l2cap_chan *chan = l2cap_pi(sk)->chan;
> > + struct l2cap_chan *chan;
> > int err = 0;
> >
> > BT_DBG("sock %p, sk %p", sock, sk);
> > @@ -803,6 +803,8 @@ static int l2cap_sock_shutdown(struct socket *sock, int how)
> > if (!sk)
> > return 0;
> >
> > + chan = l2cap_pi(sk)->chan;
> > +
>
> funny that this never caused any problems so far.
It didn't because chan is a pointer so only offset is added to sk pointer and
stored in chan. And kernel is compiled with option that prevents gcc to remove
NULL checks even if pointer was already dereferenced.
--
BR
Szymon Janc
next prev parent reply other threads:[~2012-02-14 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 13:12 [PATCH] Bluetooth: Do not dereference zero sk Emeltchenko Andrei
2012-02-14 13:12 ` Marcel Holtmann
2012-02-14 13:27 ` Szymon Janc [this message]
2012-02-16 13:17 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202141427.22053.szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox