From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mikel Astiz <mikel.astiz.oss@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: Re: [PATCH obexd v2 2/6] client: fix unreported error case
Date: Thu, 16 Feb 2012 15:07:47 +0200 [thread overview]
Message-ID: <20120216130747.GA16080@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1329230829-27046-3-git-send-email-mikel.astiz.oss@gmail.com>
Hi Mikel,
On Tue, Feb 14, 2012, Mikel Astiz wrote:
> + if (p->func) {
> + GError *gerr;
> +
> + g_set_error(&gerr, OBEX_IO_ERROR, err,
> + "Authorization failed");
This is wrong. You must initialize gerr to NULL before passing a pointer
to it to g_set_error. From the GLib documentation:
"if err is non-NULL, then *err must be NULL"
Johan
next prev parent reply other threads:[~2012-02-16 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 14:47 [PATCH obexd v2 0/6] Several minor fixes Mikel Astiz
2012-02-14 14:47 ` [PATCH obexd v2 1/6] client: fix memory leak in obc_session_put Mikel Astiz
2012-02-14 14:47 ` [PATCH obexd v2 2/6] client: fix unreported error case Mikel Astiz
2012-02-16 13:07 ` Johan Hedberg [this message]
2012-02-14 14:47 ` [PATCH obexd v2 3/6] client: fix incorrect error check Mikel Astiz
2012-02-14 14:47 ` [PATCH obexd v2 4/6] client: fix pbap select when same path given twice Mikel Astiz
2012-02-14 14:47 ` [PATCH obexd v2 5/6] client: queue transfers in ftp sessions Mikel Astiz
2012-02-14 14:47 ` [PATCH obexd v2 6/6] client: queue transfers in pbap sessions Mikel Astiz
2012-02-16 8:01 ` [PATCH obexd v2 0/6] Several minor fixes Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216130747.GA16080@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz.oss@gmail.com \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).