From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 4/4] Bluetooth: Interleaved discovery support
Date: Fri, 17 Feb 2012 00:12:13 +0200 [thread overview]
Message-ID: <20120216221213.GA3889@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1329429041-30715-5-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Thu, Feb 16, 2012, Andre Guedes wrote:
> #define INQUIRY_LEN_BREDR 0x08 /* TGAP(100) */
> +#define INQUIRY_LEN_BREDR_LE 0x04 /* TGAP(100)/2 */
> +
>
> #define SERVICE_CACHE_TIMEOUT (5 * 1000)
One unnecessary empty line added above.
> +int mgmt_interleaved_discovery(struct hci_dev *hdev)
> +{
> + int err;
> +
> + BT_DBG("%s", hdev->name);
> +
> + err = hci_do_inquiry(hdev, INQUIRY_LEN_BREDR_LE);
> + if (err < 0) {
> + hci_dev_lock(hdev);
> + hci_discovery_set_state(hdev, DISCOVERY_STOPPED);
> + hci_dev_unlock(hdev);
> + }
> +
> + return err;
> +}
The locking doesn't look right to me above. hci_do_inquiry should be
called with the lock held. I think it might be simpler if you make
mgmt_interleaved_discovery() require the caller to hold the lock.
Johan
next prev parent reply other threads:[~2012-02-16 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 21:50 [RFC 0/4] MGMT Start Discovery interleaved support Andre Guedes
2012-02-16 21:50 ` [RFC 1/4] Bluetooth: Prepare start_discovery Andre Guedes
2012-02-16 22:15 ` Johan Hedberg
2012-02-16 23:30 ` Andre Guedes
2012-02-17 8:44 ` Marcel Holtmann
2012-02-17 8:43 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 2/4] Bluetooth: Track discovery type Andre Guedes
2012-02-17 8:50 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 3/4] Bluetooth: Merge INQUIRY and LE_SCAN discovery states Andre Guedes
2012-02-17 8:50 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 4/4] Bluetooth: Interleaved discovery support Andre Guedes
2012-02-16 22:12 ` Johan Hedberg [this message]
2012-02-16 23:30 ` Andre Guedes
2012-02-17 8:48 ` Marcel Holtmann
2012-02-17 14:52 ` Johan Hedberg
2012-02-17 15:00 ` Johan Hedberg
2012-02-17 15:23 ` Ulisses Furquim
2012-02-17 15:25 ` Ulisses Furquim
2012-02-17 16:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216221213.GA3889@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).