From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Move scope of state_to_string
Date: Fri, 17 Feb 2012 11:18:14 +0200 [thread overview]
Message-ID: <20120217091812.GB19421@aemeltch-MOBL1> (raw)
In-Reply-To: <1329469930.28848.156.camel@aeonflux>
Hi Marcel,
On Fri, Feb 17, 2012 at 10:12:10AM +0100, Marcel Holtmann wrote:
> Hi Andrei,
>
> > > > Function state_to_string will be used in other files.
> > > >
> > > so long term, we need to keep socket states inside l2cap_sock.c and
> > > L2CAP states inside l2cap_core.c. Since L2CAP core engine should use the
> > > states from the specification and not try to fit into socket states.
> > >
> > > I see a little bit of value here in having them in the debug log, but
> > > making them public like this seems a big overhead. Did you measure the
> > > size difference.
> >
> > size show exactly the same size after applying this patch with my config.
> > (dynamic debug enabled)
> >
> > size net/bluetooth/bluetooth.ko
> > text data bss dec hex filename
> > 196404 12912 644 209960 33428 net/bluetooth/bluetooth.ko
>
> then I am fine with this. Just send an updated patch against the latest
> tree.
If we don't want it to be in bluetooth.h I can export only function
declaration or put it in l2cap.h. What is better?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-02-17 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 9:50 [PATCH 1/2] Bluetooth: Move scope of state_to_string Emeltchenko Andrei
2012-02-15 9:50 ` [PATCH 2/2] Bluetooth: Use symbolic name for state in debug Emeltchenko Andrei
2012-02-15 12:20 ` [PATCH 1/2] Bluetooth: Move scope of state_to_string Marcel Holtmann
2012-02-15 12:53 ` Emeltchenko Andrei
2012-02-17 9:10 ` Emeltchenko Andrei
2012-02-17 9:12 ` Marcel Holtmann
2012-02-17 9:18 ` Emeltchenko Andrei [this message]
2012-02-17 9:30 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217091812.GB19421@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox