From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mikel Astiz <mikel.astiz.oss@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: Re: [PATCH obexd v3 2/6] client: fix unreported error case
Date: Fri, 17 Feb 2012 11:51:38 +0200 [thread overview]
Message-ID: <20120217095138.GA13492@x220> (raw)
In-Reply-To: <1329400834-8400-3-git-send-email-mikel.astiz.oss@gmail.com>
Hi Mikel,
On Thu, Feb 16, 2012, Mikel Astiz wrote:
> @@ -735,17 +735,31 @@ static void session_process_queue(struct obc_session *session)
> if (session->queue == NULL || g_queue_is_empty(session->queue))
> return;
>
> + obc_session_ref(session);
> +
> while ((p = g_queue_pop_head(session->queue))) {
> int err;
>
> err = pending_request_auth(p);
> if (err == 0) {
> session->p = p;
> + obc_session_unref(session);
> return;
> }
Instead of adding the unref to any place you return in the loop, it'd be
simpler to just do a break; since you've already got the necessary unref
and end of the function right after the loop.
Johan
next prev parent reply other threads:[~2012-02-17 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 14:00 [PATCH obexd v3 0/6] Several minor fixes Mikel Astiz
2012-02-16 14:00 ` [PATCH obexd v3 1/6] client: fix memory leak in obc_session_put Mikel Astiz
2012-02-16 14:00 ` [PATCH obexd v3 2/6] client: fix unreported error case Mikel Astiz
2012-02-17 9:51 ` Johan Hedberg [this message]
2012-02-16 14:00 ` [PATCH obexd v3 3/6] client: fix incorrect error check Mikel Astiz
2012-02-17 9:54 ` Johan Hedberg
2012-02-16 14:00 ` [PATCH obexd v3 4/6] client: fix pbap select when same path given twice Mikel Astiz
2012-02-16 14:00 ` [PATCH obexd v3 5/6] client: queue transfers in ftp sessions Mikel Astiz
2012-02-16 14:00 ` [PATCH obexd v3 6/6] client: queue transfers in pbap sessions Mikel Astiz
2012-02-17 9:56 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217095138.GA13492@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz.oss@gmail.com \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).