Re: [PATCH obexd v3 6/6] client: queue transfers in pbap sessions

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Mikel,

On Thu, Feb 16, 2012, Mikel Astiz wrote:
> +struct pending_request *pending_request_new(struct pbap_data *pbap,
> +						DBusMessage *message)
> +{
> +	struct pending_request *p;
> +
> +	p = g_new0(struct pending_request, 1);
> +	p->pbap = pbap;
> +	p->msg = dbus_message_ref(message);
> +
> +	return p;
> +}

This will cause a compilation warning/error since you're not exporting
the function through any .h file. I suppose you intended to declare it
static? Also, this implies that you're not doing compilation tests with
./bootstrap-configure since it converts all warnings to errors and would
have made it impossible to compile the code. Please always use that when
writing new code.

Johan